Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bulk): upsert guardian/groot for all existing namespaces #7759

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Apr 28, 2021

Issue:
If the data was loaded into some namespace using bulk loader with --force-namespace, that data wasn't actually accessible.
This is because the users/groups were not created for it, if they were not present originally in the RDF.

Solution:
This PR fixes that by upserting the default user and password for that namespace, when the alpha starts (to be precise, whenever ACL is reset).


This change is Reviewable

@github-actions github-actions bot added area/bulk-loader Issues related to bulk loading. area/schema Issues related to the schema language and capabilities. labels Apr 28, 2021
@NamanJain8 NamanJain8 changed the title fix(bulk): reset acls for all the namespaces instead of only ns 0 fix(bulk): upsert guardian/groot for all existing namespaces Apr 28, 2021
Copy link
Contributor

@ahsanbarkati ahsanbarkati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good to have a test.

@NamanJain8 NamanJain8 merged commit c4f4964 into master Apr 29, 2021
@NamanJain8 NamanJain8 deleted the naman/reset-acl branch April 29, 2021 09:08
NamanJain8 added a commit that referenced this pull request Apr 30, 2021
Issue:
If the data was loaded into some namespace using bulk loader with --force-namespace, that data wasn't actually accessible.
This is because the users/groups were not created for it, if they were not present originally in the RDF.

Solution:
This PR fixes that by upserting the default user and password for that namespace, when the alpha starts (to be precise, whenever ACL is reset).

(cherry picked from commit c4f4964)
NamanJain8 added a commit that referenced this pull request Apr 30, 2021
Issue:
If the data was loaded into some namespace using bulk loader with --force-namespace, that data wasn't actually accessible.
This is because the users/groups were not created for it, if they were not present originally in the RDF.

Solution:
This PR fixes that by upserting the default user and password for that namespace, when the alpha starts (to be precise, whenever ACL is reset).

(cherry picked from commit c4f4964)
NamanJain8 added a commit that referenced this pull request Apr 30, 2021
…7769)

Issue:
If the data was loaded into some namespace using bulk loader with --force-namespace, that data wasn't actually accessible.
This is because the users/groups were not created for it, if they were not present originally in the RDF.

Solution:
This PR fixes that by upserting the default user and password for that namespace, when the alpha starts (to be precise, whenever ACL is reset).

(cherry picked from commit c4f4964)
NamanJain8 added a commit that referenced this pull request Jun 24, 2021
Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed.
The change was made in the PR #7759 to fix a bulk loader edge case.
This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace.
NamanJain8 added a commit that referenced this pull request Jun 24, 2021
Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed.
The change was made in the PR #7759 to fix a bulk loader edge case.
This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
NamanJain8 added a commit that referenced this pull request Jun 24, 2021
…#7924)

Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed.
The change was made in the PR #7759 to fix a bulk loader edge case.
This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
dshekhar95 pushed a commit that referenced this pull request Aug 29, 2022
----8/24/22 cherry-pick
resolved merge conflicts in acess_ee.go
----
Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed.
The change was made in the PR #7759 to fix a bulk loader edge case.
This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace.
dshekhar95 pushed a commit that referenced this pull request Sep 19, 2022
Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed.
The change was made in the PR #7759 to fix a bulk loader edge case.
This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace.
mangalaman93 pushed a commit that referenced this pull request Jan 4, 2023
Earlier, whenever the alpha starts(or restarts), we were
upserting guardian and groot for all the namespaces. This is
not actually needed. The change was made in the PR #7759 to
fix a bulk loader edge case. This PR fixes that by generating
the required RDFs in the bulk loader itself. Essentially, it
inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
mangalaman93 pushed a commit that referenced this pull request Jan 6, 2023
Earlier, whenever the alpha starts(or restarts), we were
upserting guardian and groot for all the namespaces. This is
not actually needed. The change was made in the PR #7759 to
fix a bulk loader edge case. This PR fixes that by generating
the required RDFs in the bulk loader itself. Essentially, it
inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
mangalaman93 pushed a commit that referenced this pull request Jan 17, 2023
Earlier, whenever the alpha starts(or restarts), we were
upserting guardian and groot for all the namespaces. This is
not actually needed. The change was made in the PR #7759 to
fix a bulk loader edge case. This PR fixes that by generating
the required RDFs in the bulk loader itself. Essentially, it
inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
mangalaman93 pushed a commit that referenced this pull request Jan 18, 2023
Earlier, whenever the alpha starts(or restarts), we were
upserting guardian and groot for all the namespaces. This is
not actually needed. The change was made in the PR #7759 to
fix a bulk loader edge case. This PR fixes that by generating
the required RDFs in the bulk loader itself. Essentially, it
inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
mangalaman93 pushed a commit that referenced this pull request Jan 20, 2023
Earlier, whenever the alpha starts(or restarts), we were
upserting guardian and groot for all the namespaces. This is
not actually needed. The change was made in the PR #7759 to
fix a bulk loader edge case. This PR fixes that by generating
the required RDFs in the bulk loader itself. Essentially, it
inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
mangalaman93 pushed a commit that referenced this pull request Jan 25, 2023
Earlier, whenever the alpha starts(or restarts), we were
upserting guardian and groot for all the namespaces. This is
not actually needed. The change was made in the PR #7759 to
fix a bulk loader edge case. This PR fixes that by generating
the required RDFs in the bulk loader itself. Essentially, it
inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
mangalaman93 pushed a commit that referenced this pull request Jan 31, 2023
Earlier, whenever the alpha starts(or restarts), we were
upserting guardian and groot for all the namespaces. This is
not actually needed. The change was made in the PR #7759 to
fix a bulk loader edge case. This PR fixes that by generating
the required RDFs in the bulk loader itself. Essentially, it
inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
mangalaman93 pushed a commit that referenced this pull request Jan 31, 2023
Earlier, whenever the alpha starts(or restarts), we were
upserting guardian and groot for all the namespaces. This is
not actually needed. The change was made in the PR #7759 to
fix a bulk loader edge case. This PR fixes that by generating
the required RDFs in the bulk loader itself. Essentially, it
inserts the ACL RDFs when force loading into non-Galaxy namespace.

(cherry picked from commit 6730f10)
akon-dey pushed a commit that referenced this pull request Feb 1, 2023
Earlier, whenever the alpha starts(or restarts), we were upserting
guardian and groot for all the namespaces. This is not actually needed.
The change was made in the PR #7759 to fix a bulk loader edge case. This
PR fixes that by generating the required RDFs in the bulk loader itself.
Essentially, it inserts the ACL RDFs when force loading into non-Galaxy
namespace.

(cherry picked from commit 6730f10)

Co-authored-by: Naman Jain <[email protected]>
all-seeing-code pushed a commit that referenced this pull request Feb 8, 2023
Earlier, whenever the alpha starts(or restarts), we were upserting
guardian and groot for all the namespaces. This is not actually needed.
The change was made in the PR #7759 to fix a bulk loader edge case. This
PR fixes that by generating the required RDFs in the bulk loader itself.
Essentially, it inserts the ACL RDFs when force loading into non-Galaxy
namespace.

(cherry picked from commit 6730f10)

Co-authored-by: Naman Jain <[email protected]>
all-seeing-code pushed a commit that referenced this pull request Feb 8, 2023
Earlier, whenever the alpha starts(or restarts), we were upserting
guardian and groot for all the namespaces. This is not actually needed.
The change was made in the PR #7759 to fix a bulk loader edge case. This
PR fixes that by generating the required RDFs in the bulk loader itself.
Essentially, it inserts the ACL RDFs when force loading into non-Galaxy
namespace.

(cherry picked from commit 6730f10)

Co-authored-by: Naman Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bulk-loader Issues related to bulk loading. area/schema Issues related to the schema language and capabilities.
Development

Successfully merging this pull request may close these issues.

3 participants