Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL update mutation can incorrectly remove an edge #5355

Closed
MichaelJCompton opened this issue May 4, 2020 · 0 comments · Fixed by #5356
Closed

GraphQL update mutation can incorrectly remove an edge #5355

MichaelJCompton opened this issue May 4, 2020 · 0 comments · Fixed by #5356
Labels
area/graphql Issues related to GraphQL support on Dgraph. kind/bug Something is broken. status/accepted We accept to investigate/work on it.
Milestone
Dgraph v20.03.2

Comments

@MichaelJCompton
Copy link
Contributor

Affected versions : 20.03.0 & 20.03.1

A GraphQL update mutation can remove edges that were unintended.

For example, an updatePost mutation that contains a set to an author for the post (like set: { author: { id: "0x123" } } ) can in some cases erroneously remove the edge if the author is already the author of the post.
@MichaelJCompton MichaelJCompton added kind/bug Something is broken. status/accepted We accept to investigate/work on it. area/graphql Issues related to GraphQL support on Dgraph. labels May 4, 2020
@MichaelJCompton MichaelJCompton added this to the Dgraph v20.03.2 milestone May 4, 2020
This was referenced May 4, 2020
Merged
Merged
MichaelJCompton added a commit that referenced this issue May 5, 2020
@MichaelJCompton
graphql: ensure upserts don't have accidental edge removal (#5356)
b972933 
Fixes #5355
MichaelJCompton added a commit that referenced this issue May 5, 2020
@MichaelJCompton
graphql: ensure upserts don't have accidental edge removal (#5356)
7cda57d 
Fixes #5355

(cherry-pick of b972933)
harshil-goel pushed a commit that referenced this issue May 18, 2020
@MichaelJCompton
graphql: ensure upserts don't have accidental edge removal (#5356)
0d0d70a 
Fixes #5355
@harshil-goel harshil-goel mentioned this issue May 18, 2020
Closed
harshil-goel pushed a commit that referenced this issue May 18, 2020
@MichaelJCompton
graphql: ensure upserts don't have accidental edge removal (#5356)
4f2f08a 
Fixes #5355
@harshil-goel harshil-goel mentioned this issue May 18, 2020
Closed
dna2github pushed a commit to dna2fork/dgraph that referenced this issue Jul 18, 2020
@MichaelJCompton @dna2github
graphql: ensure upserts don't have accidental edge removal (hypermode…
1304963 
…inc#5356)

Fixes hypermodeinc#5355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph. kind/bug Something is broken. status/accepted We accept to investigate/work on it.
Milestone
Dgraph v20.03.2
Development

Successfully merging a pull request may close this issue.

graphql: ensure upserts don't have accidental edge removal hypermodeinc/dgraph
1 participant
@MichaelJCompton