Let result of checkpwd to be aliased #2641
Conversation
This changes query response to use any specified alias for response.
It also brings default checkpwd response to be in-line with count().
e.g.,
```
// before
"pass": [
{
"checkpwd": true
}
]
// now
"checkpwd(pass)": true
```
Closes: #2630
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @srfrog and @manishrjain)
query/query.go, line 329 at r1 (raw file):
func addCheckPwd(pc *SubGraph, vals []*pb.TaskValue, dst outputNode) { c := types.ValueForType(types.BoolID) if len(vals) == 0 {
Is this condition not possible?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @srfrog)
query/query.go, line 329 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Is this condition not possible?
hmm not directly from query, but it could from when processing the subgraph. thanks
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
query/query.go, line 329 at r1 (raw file):
Previously, srfrog (Gus) wrote…
hmm not directly from query, but it could from when processing the subgraph. thanks
Done.
* Let result of checkpwd to be aliased
This changes query response to use any specified alias for response.
It also brings default checkpwd response to be in-line with count().
e.g.,
```
// before
"pass": [
{
"checkpwd": true
}
]
// now
"checkpwd(pass)": true
```
Closes: hypermodeinc#2630
This changes query response to use any specified alias for response.
It also brings default checkpwd response to be in-line with count().
e.g.,
Closes: #2630
This change is