Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alias on checkpwd #2630

Closed
Scapal opened this issue Oct 3, 2018 · 0 comments
Closed

alias on checkpwd #2630

Scapal opened this issue Oct 3, 2018 · 0 comments
Assignees
@srfrog
Labels
kind/bug Something is broken.

Comments

@Scapal
Copy link

Scapal commented Oct 3, 2018

Would it be possible to make the alias feature work with checkpwd ?

For the moment the aliasing doesn't work:

passwordValid: checkpwd(secret, "Password1234")

returns

"secret": [
          {
            "checkpwd": true
          }
        ]

I would expect this:

"passwordValid": true
@srfrog srfrog added the kind/bug Something is broken. label Oct 3, 2018
@srfrog srfrog self-assigned this Oct 3, 2018
srfrog pushed a commit that referenced this issue Oct 8, 2018
Let result of checkpwd to be aliased
bde4574 
This changes query response to use any specified alias for response.
It also brings default checkpwd response to be in-line with count().
e.g.,

```
// before
"pass": [
  {
    "checkpwd": true
  }
]

// now
"checkpwd(pass)": true
```

Closes: #2630
@srfrog srfrog mentioned this issue Oct 8, 2018
Merged
srfrog pushed a commit that referenced this issue Oct 9, 2018
Let result of checkpwd to be aliased (#2641)
a7c31a8 
* Let result of checkpwd to be aliased

This changes query response to use any specified alias for response.
It also brings default checkpwd response to be in-line with count().
e.g.,

```
// before
"pass": [
  {
    "checkpwd": true
  }
]

// now
"checkpwd(pass)": true
```

Closes: #2630
dna2github pushed a commit to dna2fork/dgraph that referenced this issue Jul 19, 2019
@dna2github
Let result of checkpwd to be aliased (hypermodeinc#2641)
79b9c80 
* Let result of checkpwd to be aliased

This changes query response to use any specified alias for response.
It also brings default checkpwd response to be in-line with count().
e.g.,

```
// before
"pass": [
  {
    "checkpwd": true
  }
]

// now
"checkpwd(pass)": true
```

Closes: hypermodeinc#2630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srfrog srfrog

Labels
kind/bug Something is broken.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Scapal @srfrog