Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No index on _xid_ #1074

Closed
MichaelJCompton opened this issue Jun 20, 2017 · 5 comments
Closed

No index on _xid_ #1074

MichaelJCompton opened this issue Jun 20, 2017 · 5 comments
Assignees
@janardhan1993
Milestone
v0.8

Comments

@MichaelJCompton
Copy link
Contributor

MichaelJCompton commented Jun 20, 2017 •
edited by manishrjain
Loading

Should Dgraph automatically put an exact or hash index on _xid_ if the user doesn't give one at time of bulk upload?
@manishrjain
Copy link
Contributor

Yes. We should do a hash index on it.

@manishrjain manishrjain added this to the v0.8 milestone Jun 24, 2017
@ashwin95r
Copy link
Contributor

Since we have removed the support for XIDs, do we need this? @janardhan1993

@manishrjain
Copy link
Contributor

@janardhan1993 creates an xid edge via the client. We could potentially set a hash index on it by default.

@MichaelJCompton
Copy link
Contributor Author

Would be simpler for a user to do just run dgraphloader ... -x on their RDF and then have the _xid_ edges set up with an index to use - better than requiring a user to put in their schema and manage the _xid_ edge.

janardhan1993 pushed a commit that referenced this issue Jul 11, 2017
Fixes github issues #1002 #1074 #1025
1d80ddd
janardhan1993 pushed a commit that referenced this issue Jul 11, 2017
Fixes github issues #1002 #1074 #1025 (#1170)
d11c5e6 
* Fixes github issues #1002 #1074 #1025
* renamed _xid_ to xid
@janardhan1993
Copy link
Contributor

@MichaelJCompton We set up the index automatically if user specified -x. Btw we rename xid to xid.

@manishrjain manishrjain removed the ready label Jul 11, 2017
MichaelJCompton pushed a commit that referenced this issue Jul 16, 2017
@MichaelJCompton
Fixes github issues #1002 #1074 #1025 (#1170)
22211f8 
* Fixes github issues #1002 #1074 #1025
* renamed _xid_ to xid
arijitAD pushed a commit that referenced this issue Oct 15, 2020
@noot
dot/state: update BlockState finalized block methods to accept setID (#…
202ed5f 
…1074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janardhan1993 janardhan1993

Labels
None yet
Milestone
v0.8
Development

No branches or pull requests
4 participants
@janardhan1993 @manishrjain @ashwin95r @MichaelJCompton