Address comments

hypermodeinc · Dec 10, 2020 · eac38d4 · eac38d4
1 parent 70c443f
commit eac38d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/graphql/e2e/common/query.go b/graphql/e2e/common/query.go
@@ -2927,6 +2927,7 @@ func queryAggregateWithRepeatedFields(t *testing.T) {
 				tmin : titleMin
 				tmin_again : titleMin
 				tmax: titleMax
+				tmax_again : titleMax
 				navg : numLikesAvg
 				navg2 : numLikesAvg
 			}
@@ -2942,6 +2943,7 @@ func queryAggregateWithRepeatedFields(t *testing.T) {
 								"count":4,
 								"cnt2":4,
 								"tmax": "Random post",
+								"tmax_again": "Random post",
 								"tmin": "GraphQL doco",
 								"tmin_again": "GraphQL doco",
 								"navg": 66.25,

diff --git a/graphql/resolve/query_rewriter.go b/graphql/resolve/query_rewriter.go
@@ -190,7 +190,8 @@ func aggregateQuery(query schema.Query, authRw *authRewriter) []*gql.GraphQuery
 	}
 	// Add selection set to mainQuery and finalMainQuery.
 	isAggregateFieldVisited := make(map[string]bool)
-	// isAggregateFunctionVisited stores if the aggregate function has been added or not.
+	// isAggregateFunctionVisited stores if the aggregate function for a field has been added or not.
+	// So the map entries would contain keys as nameMin, ageMin, nameName, etc.
 	isAggregateFunctionVisited := make(map[string]bool)
 	for _, f := range query.SelectionSet() {
 		fldName := f.Name()