Skip to content

Commit

Permalink
Change the default ratio of traces from 1 to 0.01. (#5405)
Browse files Browse the repository at this point in the history
Opencensus traces are taking a lot of memory.
  • Loading branch information
martinmr committed May 12, 2020
1 parent 9e85e39 commit 803fcd3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dgraph/cmd/alpha/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ they form a Raft group and provide synchronous replication.
" transaction is determined by its last mutation.")

// OpenCensus flags.
flag.Float64("trace", 1.0, "The ratio of queries to trace.")
flag.Float64("trace", 0.01, "The ratio of queries to trace.")
flag.String("jaeger.collector", "", "Send opencensus traces to Jaeger.")
// See https://github.com/DataDog/opencensus-go-exporter-datadog/issues/34
// about the status of supporting annotation logs through the datadog exporter
Expand Down
2 changes: 1 addition & 1 deletion dgraph/cmd/zero/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ instances to achieve high-availability.
flag.Bool("enable_sentry", true, "Turn on/off sending events to Sentry (default on).")

// OpenCensus flags.
flag.Float64("trace", 1.0, "The ratio of queries to trace.")
flag.Float64("trace", 0.01, "The ratio of queries to trace.")
flag.String("jaeger.collector", "", "Send opencensus traces to Jaeger.")
// See https://github.com/DataDog/opencensus-go-exporter-datadog/issues/34
// about the status of supporting annotation logs through the datadog exporter
Expand Down

0 comments on commit 803fcd3

Please sign in to comment.