Fix race condition in numShutDownSig in alpha

hypermodeinc · May 14, 2019 · 0ea0df3 · 0ea0df3
1 parent 4ed87b5
commit 0ea0df3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/dgraph/cmd/alpha/run.go b/dgraph/cmd/alpha/run.go
@@ -555,7 +555,8 @@ func run() {
 			}
 		}
 	}()
-	_ = numShutDownSig
+	// TODO (animesh): Not sure why this was done in the first place
+	// _ = numShutDownSig
 
 	// Setup external communication.
 	aclCloser := y.NewCloser(1)

diff --git a/worker/groups.go b/worker/groups.go
@@ -289,8 +289,6 @@ func (g *groupi) applyState(state *pb.MembershipState) {
 }
 
 func (g *groupi) ServesGroup(gid uint32) bool {
-	// No need to acquire the lock on g because gid is always
-	// accessed atomically via groupId() function
 	return g.groupId() == gid
 }