add new JSON for Grafana dashboard #39

MichelDiz · 2020-03-25T18:05:07Z

This is a work in progress as some metrics have issues see => hypermodeinc/dgraph#4772

This change is

danielmai

We can add rate panels for both queries and mutations.

I like the gauges showing the memory usage for all the different instances. But, the thresholds can be better. It's always showing it in the Red threshold for me.

Reviewable status: 0 of 1 files reviewed, 8 unresolved discussions (waiting on @danielmai and @MichelDiz)

scripts/grafana_dashboard.json, line 151 at r1 (raw file):

          "timeFrom": null,
          "timeShift": null,
          "title": "Zero and Alpha",

This Panel is empty for me.

Can we remove this if this isn't showing anything? Or, do I need to use a specific version of Grafana? I'm currently using 6.1.6.

scripts/grafana_dashboard.json, line 224 at r1 (raw file):

          "targets": [
              {
                  "expr": "sum(dgraph_num_edges_total{instance=~'$Instance'})",

This is the number of processed mutations. So, it can be in a chart just like the "Processed Queries" chart.

scripts/grafana_dashboard.json, line 346 at r1 (raw file):

          "options": {},
          "pluginVersion": "6.6.1",
          "postfix": " /queries",

This metric is cut off for me.

scripts/grafana_dashboard.json, line 438 at r1 (raw file):

          "targets": [
              {
                  "expr": "dgraph_memory_inuse_bytes+dgraph_memory_idle_bytes{instance=~'$Instance'}",

In Grafana the legend doesn't show what this metric is. We should give a label.

Inuse+Idle ({{instance}})

scripts/grafana_dashboard.json, line 449 at r1 (raw file):

                  "intervalFactor": 2,
                  "legendFormat": "",
                  "metric": "dgraph_memory_proc_bytes",

We can give a cleaner label for metrics.

This one can be

`Proc ({{instance}})

scripts/grafana_dashboard.json, line 828 at r1 (raw file):

              {
                  "expr": "dgraph_num_queries_total",
                  "format": "heatmap",

This should be Time series

scripts/grafana_dashboard.json, line 1111 at r1 (raw file):

              {
                  "expr": "dgraph_raft_applied_index{instance=~'$Instance'}",
                  "format": "heatmap",

This should be the time-series format.

scripts/grafana_dashboard.json, line 1301 at r1 (raw file):

          "targets": [
              {
                  "expr": "go_threads",

go_goroutines is a better metric to look at than go_threads.

MichelDiz

I think the version you are using must have some issues. Check this docker compose https://gist.github.com/MichelDiz/42954e321620159c872c35c20e9d85c6 I'm using this to test the grafana.

Also, I have added a modified JSON based on your comments https://gist.github.com/MichelDiz/42954e321620159c872c35c20e9d85c6#file-grafana_dgraphv2-json

Take a look at this screenshot hypermodeinc/dgraph#4759 (comment)

Reviewable status: 0 of 1 files reviewed, 8 unresolved discussions (waiting on @danielmai)

scripts/grafana_dashboard.json, line 151 at r1 (raw file):