Fix(builder): Too many small tables when compression is enabled #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
manishrjain
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ahsanbarkati, @ashish-goswami, and @jarifibrahim)
table/builder.go, line 364 at r1 (raw file):
5*(uint32(len(b.tableIndex.Offsets))) // approximate index size return estimateSz >= uint32(float64(cap)*0.90)
Do the calculation upfront, and set cap to that calculation.
jarifibrahim
reviewed
Oct 2, 2020
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 5, 2020
…ed (#1549)" This reverts commit 5d1bab4. We'reverting this commit because it seems to cause a strange issue while writing data. Running `go run -tags main.go benchmark write --sorted --compression=true --block-cache-mb=100` creates a directory which does not have all the keys. I don't know why this would fix the issue but the test works fine after reverting this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of too many sst files of very small sizes when compression is enabled. We now account for the actual sizes of blocks after compression and we assume that the table capacity is reached if the sum of actual sizes of block buffers is more than 90% of the table capacity.
This change is