Use WAL instead of Vlog for crash recovery. #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
NamanJain8
force-pushed
the
naman/wal
branch
from
8bbe1a9 to
a1c0e2e
Compare
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
| require.NoError(t, y.Munmap(db.vlog.filesMap[db.vlog.maxFid].fmap)) | ||
| for _, f := range db.vlog.filesMap { | ||
| require.NoError(t, y.Munmap(db.vlog.vlog.filesMap[db.vlog.vlog.maxFid].fmap)) | ||
| for _, f := range db.vlog.vlog.filesMap { |
There was a problem hiding this comment.
Call vlog as logManager
| @@ -861,7 +949,7 @@ func (db *DB) writeRequests(reqs []*request) error { | |||
| return errors.Wrap(err, "writeRequests") | |||
| } | |||
| db.Lock() | |||
| db.updateHead(b.Ptrs) | |||
| db.updateHead([]valuePointer{b.head}) | |||
db.go
Outdated
| @@ -137,7 +217,12 @@ func (db *DB) replayFunction() func(Entry, valuePointer) error { | |||
| nv = make([]byte, len(e.Value)) | |||
| copy(nv, e.Value) | |||
| } else { | |||
| nv = vp.Encode() | |||
| // Write to vlog and get the value pointer to vlog | |||
| vlogP, err := toVlog(&e) | |||
There was a problem hiding this comment.
We'll need a test for this.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
status/stale
|
Closing this as this is not needed now. #1555 was merged which fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-2177
This PR separates smaller values from vlog and instead stores it in WAL.
This leads to minimization of disk usage as WAL files can be easily cleaned.
Smaller values ( <ValueThreshold ): WAL -> LSM
Bigger values : WAL -> Vlog -> LSM
This change is