release/v2.2007 - Rework Block and Index cache (#1473) #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
This PR separates the block cache and the index cache. Earlier we had a mix of both the caches. Block Cache -> Stores block. Should be used when running badger with compression/encryption Index Cache -> Used to limit the memory used by table indices and bloom filters. This PR also remove the `KeepBlocksInCache` and `KeepBlockIndicesInCache` options. (cherry picked from commit c3b1582)
jarifibrahim
force-pushed
the
ibrahim/r2.2007-cherry-picks
branch
from
dee4499 to
5504a51
Compare
NamanJain8
approved these changes
Aug 26, 2020
ahsanbarkati
approved these changes
Aug 26, 2020
NamanJain8
added a commit
to hypermodeinc/dgraph
that referenced
this pull request
Aug 27, 2020
Badger now has 2 separate caches blockCache and indexCache (see hypermodeinc/badger#1476) This PR adds --cache_mb and --cache_percentage flags for alpha and zero. The total cache is split among various caches used by zero and alpha based on percentages defined. Cache size is in MBs and format of caches is as follows For alpha: PostingListCache,PstoreBlockCache,PstoreIndexCache,WstoreBlockCache,WstoreIndexCache For zero: blockCache,indexCache
This was referenced Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a bunch of conflicts. Please review it thoroughly.
This PR separates the block cache and the index cache. Earlier we had a mix of both the caches.
Block Cache -> Stores block. Should be used when running badger with compression/encryption
Index Cache -> Used to limit the memory used by table indices and bloom filters.
This PR also remove the
KeepBlocksInCacheandKeepBlockIndicesInCacheoptions.(cherry picked from commit c3b1582)
This change is