Fix build on Plan 9 #1451
Merged
Fix build on Plan 9 #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation.
fhs
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
|
|
jarifibrahim
reviewed
Aug 5, 2020
There was a problem hiding this comment.
This is awesome work @fhs 🎉. Thank you for fixing this. I have some comments.
I'm wondering how do we test this PR. Can you also add a GOOS=plan9 build to travis CI?
Co-authored-by: Ibrahim Jarif <[email protected]>
jarifibrahim
reviewed
Aug 5, 2020
|
I've added |
NamanJain8
reviewed
Aug 10, 2020
NamanJain8
reviewed
Aug 10, 2020
Co-authored-by: Ibrahim Jarif <[email protected]>
jarifibrahim
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
LGTM. Thanks for the PR @fhs 🎉 . I made one small line length change on this PR.
I'll merge this PR once CI finishes.
|
When can I expect this to be included in a release? I need this in a v1.6.x release to get ipfs working, but I can also wait for v1.7.0. IPFS tracking issue for Plan 9 support: ipfs/kubo#7575 |
|
We will be doing a badger 1.x release this week. This patch would be in that release. @NamanJain8 This needs to go in 1.x release. |
NamanJain8
pushed a commit
that referenced
this pull request
Sep 8, 2020
Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <[email protected]> (cherry picked from commit 07fa3eb)
NamanJain8
added a commit
that referenced
this pull request
Sep 9, 2020
Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <[email protected]> (cherry picked from commit 07fa3eb) Co-authored-by: Fazlul Shahriar <[email protected]>
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <[email protected]>
|
Looks like this was never backported to badger v2. Could we make that happen? Building against |
francislavoie
added a commit
to francislavoie/badger
that referenced
this pull request
Aug 23, 2021
Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <[email protected]> (cherry picked from commit 07fa3eb) Co-authored-by: Fazlul Shahriar <[email protected]>
danielmai
pushed a commit
that referenced
this pull request
Aug 24, 2021
Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <[email protected]> (cherry picked from commit 07fa3eb) Co-authored-by: Fazlul Shahriar <[email protected]> Co-authored-by: Fazlul Shahriar <[email protected]>
mYmNeo
pushed a commit
to mYmNeo/badger
that referenced
this pull request
Jan 16, 2023
Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <[email protected]> (cherry picked from commit 07fa3eb) Co-authored-by: Fazlul Shahriar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan 9 doesn't have mmap, so we just return an error.
File locking is implemented using the exclusive mode bit.
From http://man.cat-v.org/plan_9/5/open:
Initial attempt at implementing directory locking using this method was
not successful because badger seems to be opening the directory multiple
times (at least while running the test suite). As a workaround, we lock
the pid lock file instead of the directory itself, same as the windows
implementation.
This change is