levels: Cleanup builder resources on building an empty table #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damz
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
jarifibrahim
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
The compaction process can leak `*table.Builder` instances if the table built is empty. This used to be a big problem: before #1409 it would leak out the block compression/encryption goroutines (that are all blocked on reading from the `b.blockChan`, and because of that, it would leak the builder too. Since #1409 this is now a simple question of correctness. Take it or leave it.
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Jan 17, 2023
…einc#1414 Signed-off-by: thomassong <[email protected]>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Feb 13, 2023
…einc#1414 Signed-off-by: thomassong <[email protected]>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Sep 14, 2024
…einc#1414 Signed-off-by: thomassong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compaction process can leak
*table.Builderinstances if the table built is empty.This used to be a big problem: before #1409 it would leak out the block compression/encryption goroutines (that are all blocked on reading from the
b.blockChan, and because of that it would leak the builder too.Since #1409 this is now a simple question of correctness. Take it or leave it.
This change is