Implement common subexpression elimination #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
force-pushed
the
common-subexpression-elimination
branch
from
3a61cb2
to
c74fec1
Compare
LucasSte
commented
Nov 4, 2021
|
The codegen test fails randomly, that's why the mac/windows tests have failed. |
LucasSte
force-pushed
the
common-subexpression-elimination
branch
from
87ffbd6
to
a4cdd1b
Compare
|
Please can you merge your commits into one commit, or more than one if it makes sense. It would be nice if commits are a set of logical changes. Also please ensure your commits have the correct |
LucasSte
force-pushed
the
common-subexpression-elimination
branch
2 times, most recently
from
143c08f
to
53074dc
Compare
seanyoung
reviewed
Nov 11, 2021
seanyoung
requested changes
Nov 11, 2021
| @@ -1254,6 +1257,10 @@ pub fn optimize_and_check_cfg( | |||
| if opt.dead_storage { | |||
| dead_storage::dead_storage(cfg, ns); | |||
| } | |||
|
|
|||
| if opt.common_subexpression_elimination && func_no.is_some() { | |||
There was a problem hiding this comment.
Any reason for func_no.some()?
A default constructor has no function number, so it is None in that case.
There was a problem hiding this comment.
A default constructor has no sub expression to be optimized.
There was a problem hiding this comment.
True, although that is worth a comment.
Signed-off-by: Lucas Steuernagel <[email protected]>
LucasSte
force-pushed
the
common-subexpression-elimination
branch
from
4990368
to
1ff5dc8
Compare
seanyoung
approved these changes
Nov 12, 2021
seanyoung
added a commit
to seanyoung/solang
that referenced
this pull request
Mar 1, 2022
Added - On Solana, the accounts that were passed into the transactions are listed in the `tx.accounts` builtin. There is also a builtin struct `AccountInfo` - A new common subexpression elimination pass was added, thanks to [LucasSte](hyperledger#550) - A graphviz dot file can be generated from the ast, using `--emit ast-dot` - Many improvements to the solidity parser, and the parser has been spun out in it's own create `solang-parser`. Changed - Solang now uses LLVM 13.0, based on the [Solana LLVM tree](https://github.com/solana-labs/llvm-project/) - The ast datastructure has been simplified. - Many bugfixes across the entire tree. Signed-off-by: Sean Young <[email protected]>
seanyoung
added a commit
to seanyoung/solang
that referenced
this pull request
Mar 1, 2022
Added - On Solana, the accounts that were passed into the transactions are listed in the `tx.accounts` builtin. There is also a builtin struct `AccountInfo` - A new common subexpression elimination pass was added, thanks to [LucasSte](hyperledger#550) - A graphviz dot file can be generated from the ast, using `--emit ast-dot` - Many improvements to the solidity parser, and the parser has been spun out in it's own create `solang-parser`. Changed - Solang now uses LLVM 13.0, based on the [Solana LLVM tree](https://github.com/solana-labs/llvm-project/) - The ast datastructure has been simplified. - Many bugfixes across the entire tree. Signed-off-by: Sean Young <[email protected]>
seanyoung
added a commit
that referenced
this pull request
Mar 1, 2022
Added - On Solana, the accounts that were passed into the transactions are listed in the `tx.accounts` builtin. There is also a builtin struct `AccountInfo` - A new common subexpression elimination pass was added, thanks to [LucasSte](#550) - A graphviz dot file can be generated from the ast, using `--emit ast-dot` - Many improvements to the solidity parser, and the parser has been spun out in it's own create `solang-parser`. Changed - Solang now uses LLVM 13.0, based on the [Solana LLVM tree](https://github.com/solana-labs/llvm-project/) - The ast datastructure has been simplified. - Many bugfixes across the entire tree. Signed-off-by: Sean Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements common subexpression elimination for the Solang compiler. It runs an available expression analysis during the first pass. Then, during a second pass we exchange common expressions by a temporaries.
This PR is the last milestone for the Linux Mentorship for the Hyperledger foundation. For more information about the project, please check the wiki.