Unused variable detection #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
force-pushed
the
unused-variable-detection
branch
from
899c925
to
524d119
Compare
seanyoung
requested changes
Jul 4, 2021
|
Also please squash all your work into a single commit once you are done - or a few commits if each commit makes logical sense. |
LucasSte
force-pushed
the
unused-variable-detection
branch
2 times, most recently
from
571b295
to
5c2b19b
Compare
Signed-off-by: LucasSte <[email protected]>
LucasSte
force-pushed
the
unused-variable-detection
branch
5 times, most recently
from
e3a2cee
to
8edac3e
Compare
seanyoung
requested changes
Jul 8, 2021
LucasSte
commented
Jul 8, 2021
LucasSte
force-pushed
the
unused-variable-detection
branch
from
2f71a12
to
797ba4e
Compare
seanyoung
requested changes
Jul 8, 2021
LucasSte
force-pushed
the
unused-variable-detection
branch
from
154e261
to
0e14dac
Compare
|
Would you mind rebasing against latest main, so it can be merged and also squashing the commits into one. Thanks. |
Signed-off-by: LucasSte <[email protected]>
LucasSte
force-pushed
the
unused-variable-detection
branch
from
d8c83ba
to
76e520c
Compare
I left two commits: one for the code itself and another for the tests. |
seanyoung
approved these changes
Jul 9, 2021
This was referenced Jul 12, 2021
seanyoung
added a commit
to seanyoung/solang
that referenced
this pull request
Aug 27, 2021
Added - Added a strength reduce pass to eliminate 256/128 bit multiply, division, and modulo where possible. - Visual Studio Code extension can download the Solang binary from github releases, so the user is not required to download it themselves - The Solana target now has support for arrays and mapping in contract storage - The Solana target has support for the keccak256(), ripemd160(), and sha256() builtin hash functions. - The Solana target has support for the builtins this and block.timestamp. - Implement abi.encodePacked() for the ethereum abi encoder - The Solana target now compiles all contracts to a single `bundle.so` BPF program. - Any unused variables, events, or contract variables are now detected and warnings are given, thanks to [LucasSte](hyperledger#429) - The `immutable` attribute on contract storage variables is now supported. - The `override` attribute on public contract storage variables is now supported. - The `unchecked {}` code block is now parsed and supported. Math overflow still is unsupported for types larger than 64 bit. - `assembly {}` blocks are now parsed and give a friendly error message. - Any variable use before it is given a value is now detected and results in a undefined variable diagnostic, thanks to [LucasSte](hyperledger#468) Changed - Solang now uses LLVM 12.0, based on the [Solana LLVM tree](https://github.com/solana-labs/llvm-project/) Fixed - Fix a number of issues with parsing the uniswap v2 contracts - ewasm: staticcall() and delegatecall() cannot take value argument - Fixed array support in the ethereum abi encoder and decoder - Fixed issues in arithmetic on non-power-of-2 types (e.g. uint112) Signed-off-by: Sean Young <[email protected]>
seanyoung
added a commit
that referenced
this pull request
Aug 27, 2021
Added - Added a strength reduce pass to eliminate 256/128 bit multiply, division, and modulo where possible. - Visual Studio Code extension can download the Solang binary from github releases, so the user is not required to download it themselves - The Solana target now has support for arrays and mapping in contract storage - The Solana target has support for the keccak256(), ripemd160(), and sha256() builtin hash functions. - The Solana target has support for the builtins this and block.timestamp. - Implement abi.encodePacked() for the ethereum abi encoder - The Solana target now compiles all contracts to a single `bundle.so` BPF program. - Any unused variables, events, or contract variables are now detected and warnings are given, thanks to [LucasSte](#429) - The `immutable` attribute on contract storage variables is now supported. - The `override` attribute on public contract storage variables is now supported. - The `unchecked {}` code block is now parsed and supported. Math overflow still is unsupported for types larger than 64 bit. - `assembly {}` blocks are now parsed and give a friendly error message. - Any variable use before it is given a value is now detected and results in a undefined variable diagnostic, thanks to [LucasSte](#468) Changed - Solang now uses LLVM 12.0, based on the [Solana LLVM tree](https://github.com/solana-labs/llvm-project/) Fixed - Fix a number of issues with parsing the uniswap v2 contracts - ewasm: staticcall() and delegatecall() cannot take value argument - Fixed array support in the ethereum abi encoder and decoder - Fixed issues in arithmetic on non-power-of-2 types (e.g. uint112) Signed-off-by: Sean Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements unused variable detection for the Solang compiler.
It generates warnings for unused state variables, global constants and contract storage.
As a bonus, I implemented the detection of events that have never been emitted.
This PR also implements tests for the new code.
This is the first milestone for the Linux Foundation mentorship on the Solang compiler.
For more information, please refer to the project plan.