Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is better to use the repository field in Cargo.toml #1655

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

szabgab
Copy link
Contributor

@szabgab szabgab commented Jun 25, 2024

To allow Crates.io , lib.rs and the Rust Digger to link to it. See the manifest for the explanation.

Copy link
Contributor

@seanyoung seanyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually would you mind making the same change to parser/Cargo.toml for the solang-parser crate. Thanks!

Signed-off-by: Gábor Szabó <[email protected]>
@szabgab
Copy link
Contributor Author

szabgab commented Jun 25, 2024

did you mean that?

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (399c199) to head (41653f5).

Current head 41653f5 differs from pull request most recent head cdaa1e8

Please upload reports for the commit cdaa1e8 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1655   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files         164      164           
  Lines       73152    73152           
=======================================
+ Hits        64799    64802    +3     
+ Misses       8353     8350    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seanyoung seanyoung merged commit b00f617 into hyperledger:main Jun 25, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants