v0.3.2 Brasília #1496
Merged
v0.3.2 Brasília #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
reviewed
Aug 21, 2023
|
|
||
| ### Added | ||
| - Go to definition is now implemented in the language server. [chioni16](https://github.com/chioni16) | ||
| - The parser has been updated to be compatible with Ethereum Solidity v0.8.21. [seanyoung](https://github.com/seanyoung) | ||
|
|
||
| ### Fixed |
There was a problem hiding this comment.
I fixed the overflowing problem in the tranfer function and avoided overwriting the signer and writer flags. Are these bug fixes worth mentioning?
There was a problem hiding this comment.
The changelog should really list things which are user-affecting, in a consumable way. This is a security change, so yes this can be mentioned.
There was a problem hiding this comment.
I've added an entry for these two items
xermicus
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
@seanyoung I forgot that my PRs regarding errors and reverting also fixed some try-catch issues.
LucasSte
approved these changes
Aug 22, 2023
|
I'd like to have #1497 in the release - it's a feature which has been requested a few times. |
|
Since we are waiting anyways, can #1501 go in too? It's a 🤏 bugfix and would be good to have in |
The language server is much improved, and many fixes all over. ### Added - Go to definition is now implemented in the language server. [chioni16](https://github.com/chioni16) - The parser has been updated to be compatible with Ethereum Solidity v0.8.21. [seanyoung](https://github.com/seanyoung) - **Polkadot** Support for runtimes built with on `polkadot-v1.0.0` ### Fixed - **breaking** Resolving import paths now matches solc more closely, and only resolves relative paths when specified as `./foo` or `../foo`. [seanyoung](https://github.com/seanyoung) - **Solana** The `lamports` and `data` fields of `tx.accounts` can be modified again. [LucasSte](https://github.com/LucasSte) - **Solana** The `address.transfer()` and `address.send()` functions no longer change any balances in the error case if there was an overflow (e.g. not enough balance). [LucasSte](https://github.com/LucasSte) - **Solana** When collecting the required accounts, ensure that the writer and signer bits are set correctly if the same account is used multiple times. [LucasSte](https://github.com/LucasSte) - It is not longer necessary to save a Solidity file, in order for the language server to pick up changes to the file. [chioni16](https://github.com/chioni16) - The negate operator `-` now checks for overflow at runtime, and other math overflow fixes. [seanyoung](https://github.com/seanyoung) - Fixed a bug where accessing the function selector of virtual functions might cause a compiler panic. [xermicus](https://github.com/xermicus) - Fixed a bug where the strength reduce optimization pass removed overflow checks on optimized multiplications. [xermicus](https://github.com/xermicus) - Fixed a bug where external function variables were not marked as `read` when they were called by the semantic analyzer, which could lead to the external function call being eliminated spuriously. [xermicus](https://github.com/xermicus) - Fixed a bug in `try-catch` where a failed transfer trapped the contract instead of handling it in a catch all block. [xermicus](https://github.com/xermicus) ### Changed - The Substrate target has been renamed to Polkadot. [xermicus](https://github.com/xermicus) - **Polkadot** `assert()` and `require()` is now implemented as a transction revert, rather than a trap. The error data is returned, and encoded the same as on Ethereum. Error data is now passed to the calling contract, all the way up the call stack. [xermicus](https://github.com/xermicus) - **Polkadot** constructor can be non-payable. [xermicus](https://github.com/xermicus) - Storage variables are now always written to, regardless whether the contract does read them or not. Prior behavior was to not write to storage variables if they are not read, which can remove wanted side effects, because unused storage variables may be used in future versions of the contract. [xermicus](https://github.com/xermicus) - **Solana** seeds can now be of type `address` or `bytesN`, in addition to `bytes`. [seanyoung](https://github.com/seanyoung) Signed-off-by: Sean Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The language server is much improved, and many fixes all over.
Added
Fixed
./fooor../foo. seanyounglamportsanddatafields oftx.accountscan be modified again. LucasSte-now checks for overflow at runtime, and other math overflow fixes. seanyoungChanged
assert()andrequire()is now implemented as a transction revert, rather than a trap. The error data is returned, and encoded the same as on Ethereum. Error data is now passed to the calling contract, all the way up the call stack. xermicus