Refactor constructor annotations #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
force-pushed
the
syntax-change
branch
2 times, most recently
from
e19435a
to
b939c24
Compare
seanyoung
reviewed
Jun 16, 2023
|
There are no testcases with whitespace between |
The entire annotation is now a token. There is no way of declaring an annotation with a whitespace between the |
seanyoung
reviewed
Jun 19, 2023
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
seanyoung
approved these changes
Jun 21, 2023
Signed-off-by: Lucas Steuernagel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, we can declare an account on a Solana constructor using the
@payer(my_account)annotation, while@seed(my_seed)refers to a constructor parameter. Such a construction is confusing for the same syntax have two different meanings.This PR limits the scope of annotation above a constructor to accept only literals as parameters (e.g.
@seed("pine_tree")). Annotations that refer to function parameters must appear before them:constructor (@seed bytes arg1). This is another in #1251.