-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-opt
for Substrate
#1365
wasm-opt
for Substrate
#1365
Conversation
Signed-off-by: xermicus <[email protected]>
Signed-off-by: xermicus <[email protected]>
Signed-off-by: xermicus <[email protected]>
Signed-off-by: xermicus <[email protected]>
Signed-off-by: xermicus <[email protected]>
Co-authored-by: Lucas Steuernagel <[email protected]> Signed-off-by: Cyrill Leutwiler <[email protected]>
…rate unit tests by default Signed-off-by: Cyrill Leutwiler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling the wasm_opt feature without the llvm feature makes no sense, but I don't know what we can do about that (and if it matters).
…alid Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Agreed, however we can't tie it together with the But what we can do is to automatically enable |
The more I think about it, the more I think it doesn't matter |
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
@LucasSte yeah I forgot to commit that, thanks |
wasm-opt
brings some great optimizations and we should use it (cargo contract
uses it for ink contracts). For example, the Wasm blob of our flipper example (compile--release
) goes down from 2.2kb to 1.2kb.