v0.3.0 Venice #1319
Merged
v0.3.0 Venice #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xermicus
approved these changes
May 22, 2023
LucasSte
reviewed
May 22, 2023
CHANGELOG.md
Outdated
| @@ -2,6 +2,36 @@ | |||
| All notable changes to [Solang](https://github.com/hyperledger/solang/) | |||
| will be documented here. | |||
|
|
|||
| ## v0.3.0 Venice | |||
|
|
|||
| The parser and semantic analysis stage of Solang have been through | |||
There was a problem hiding this comment.
I think have gone through or underwent sounds better than have been through.
There was a problem hiding this comment.
I've changed to have gone through but I have a hard time seeing any difference - other than taste.
CHANGELOG.md
Outdated
| `cargo test`. | ||
| [seanyoung](https://github.com/seanyoung) | ||
| - If a function returned a `storage` reference, then not returning a value explicitly is an error, since | ||
| the reference must post refer to an existing variable. |
There was a problem hiding this comment.
I think that was a brain misfire, I am sure I was thinking about the variables post function execution. Anyway fixed
| [seanyoung](https://github.com/seanyoung) | ||
| [xermicus](https://github.com/xermicus) | ||
| [LucasSte](https://github.com/LucasSte) | ||
|
|
There was a problem hiding this comment.
Is is worth mentioning the changes in the stdlib?
Tests are now enabled and we build the files when running cargo build. These changes do not affect the users in any way, so they are not really worth a place in the change log.
There was a problem hiding this comment.
I would say the changelog should only document user-facing changes.
LucasSte
approved these changes
May 22, 2023
The parser and semantic analysis stage of Solang have gone through [a security audit](https://github.com/solana-labs/security-audits/blob/master/solang/Trail_of_Bits_Solang_Final_report.pdf). All security issues have been fixed. ### Added - The CLI now has a `--release` option, which disables printing of errors [salaheldinsoliman](https://github.com/salaheldinsoliman) - **Substrate**: chain extensions can be now used. [xermicus](https://github.com/xermicus) ### Fixed - Solidity error definitions are now parsed. [seanyoung](https://github.com/seanyoung) - The Ethereum Solidity parser and semantic analysis tests are now run on Solang sema during `cargo test`. [seanyoung](https://github.com/seanyoung) - If a function returns a `storage` reference, then not returning a value explicitly is an error, since the reference must refer to an existing storage variable. [seanyoung](https://github.com/seanyoung) - Many small improvements have been made to the parser and semantic analysis, improving compatibility with Ethereum Solidity. [seanyoung](https://github.com/seanyoung) [xermicus](https://github.com/xermicus) [LucasSte](https://github.com/LucasSte) ### Changed - **Solana**: Addresses are now base58 encoded when formated with `"address:{}".format(address)`. [LucasSte](https://github.com/LucasSte) - **Substrate**: No longer use the prefixed names for seal runtime API calls, which grants small improvements in contract sizes. [xermicus](https://github.com/xermicus) Signed-off-by: Sean Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser and semantic analysis stage of Solang have gone through
a security audit. All security issues have been fixed.
Added
--releaseoption, which disables printing of errors salaheldinsolimanxermicus
Fixed
seanyoung
cargo test.seanyoung
storagereference, then not returning a value explicitly is an error, sincethe reference must refer to an existing storage variable.
seanyoung
with Ethereum Solidity.
seanyoung
xermicus
LucasSte
Changed
"address:{}".format(address).LucasSte