Indy 1256 propagare primary #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dsurnin <[email protected]>
… zero view Signed-off-by: dsurnin <[email protected]>
| assert (new_primary.name == old_primary.name) | ||
|
|
||
| # check ppSeqNo the same | ||
| _get_ppseqno(txnPoolNodeSet) |
There was a problem hiding this comment.
Should we have assert old_ppseqno == _get_ppseqno(txnPoolNodeSet) ?
There was a problem hiding this comment.
It is almost the same - this call will check that ppSeqNo is the same in all nodes and will raise exception otherwise
| assert (new_primary.name == old_primary.name) | ||
|
|
||
| # check ppSeqNo the same | ||
| _get_ppseqno(txnPoolNodeSet) |
There was a problem hiding this comment.
Should we have assert old_ppseqno == _get_ppseqno(txnPoolNodeSet) ?
There was a problem hiding this comment.
It is almost the same - this call will check that ppSeqNo is the same in all nodes and will raise exception otherwise
Signed-off-by: dsurnin <[email protected]>
|
test this please |
3 similar comments
|
test this please |
|
test this please |
|
test this please |
Signed-off-by: dsurnin <[email protected]>
Signed-off-by: dsurnin <[email protected]>
|
test this please |
|
tert this please |
|
test this please |
|
test this please |
Signed-off-by: dsurnin <[email protected]>
|
test this please |
ashcherbakov
approved these changes
Apr 25, 2018
lovesh
pushed a commit
to evernym/indy-plenum
that referenced
this pull request
May 3, 2018
* use libindy 454 Signed-off-by: dsurnin <[email protected]> * Add from current state flag to be able to process veiw change done on zero view Signed-off-by: dsurnin <[email protected]> * Extend testing timeout Signed-off-by: dsurnin <[email protected]> * Fix pyt5est collect on jenkins Signed-off-by: dsurnin <[email protected]> * Revert changes Signed-off-by: dsurnin <[email protected]> * Fix current_state processing Signed-off-by: dsurnin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.