Public/indy 1265 #622
Merged
Public/indy 1265 #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2018 18:24
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
dsurnin
approved these changes
Apr 11, 2018
Signed-off-by: Andrew Nikitin <[email protected]>
|
test this please |
| try: | ||
| looper.loop.run_until_complete(close_pool_ledger(pool_handle)) | ||
| except Exception as e: | ||
| logger.debug("Unhandled exception: {}".format(e)) |
There was a problem hiding this comment.
does it make sense to use logger.exception() for more informative log record?
There was a problem hiding this comment.
Instruction in try except block will be implemented in "pytest shutdown procedure", therefore it's only for hiding purposes.
andkononykhin
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.