refactoring and new tests #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lovesh Harchandani <[email protected]>
plenum/server/node.py
Outdated
| @@ -2563,11 +2567,16 @@ def updateSeqNoMap(self, committedTxns): | |||
|
|
|||
| def commitAndSendReplies(self, reqHandler, ppTime, reqs: List[Request], | |||
| stateRoot, txnRoot) -> List: | |||
| logger.debug('{} going to commit and send replies to client'.format(self)) | |||
There was a problem hiding this comment.
I think it needs to have trace level
| @@ -0,0 +1,137 @@ | |||
| import random | |||
There was a problem hiding this comment.
Should we remove this file?
Signed-off-by: Lovesh Harchandani <[email protected]>
ashcherbakov
previously approved these changes
Mar 29, 2018
Signed-off-by: Lovesh Harchandani <[email protected]>
ashcherbakov
previously approved these changes
Mar 29, 2018
Signed-off-by: Lovesh Harchandani <[email protected]>
| if self.reached_end is True: | ||
| raise StopIteration | ||
| item = next(self.iterator) | ||
| key = item[0] if isinstance(item, tuple) else item |
There was a problem hiding this comment.
Why we do a special handling for tuples?
There was a problem hiding this comment.
Because the iterator self.iterator might be over over keys (iterkeys) or key and values both (iteritems)
ashcherbakov
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lovesh Harchandani [email protected]