[INDY-1210] Added resending instance change messages #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 27, 2018 15:45
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
| assert set([n.view_changer.instance_change_rounds for n in txnPoolNodeSet]) == {1} | ||
|
|
||
| looper.runFor(tconf.INSTANCE_CHANGE_TIMEOUT) | ||
| looper.run(eventually(partial(checkViewNoForNodes, txnPoolNodeSet, expectedViewNo=old_view_no + 1), |
There was a problem hiding this comment.
Can we check that the pool is working after this?
Signed-off-by: Andrew Nikitin <[email protected]>
ashcherbakov
approved these changes
Mar 28, 2018
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
* [INDY-1210] Test which check disconnect not primary and primary node Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1210] Added instance change messages resending Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1210] Flake8 code validation Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1210] Added check, that pool works after view_change Signed-off-by: Andrew Nikitin <[email protected]>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
* [INDY-1210] Test which check disconnect not primary and primary node Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1210] Added instance change messages resending Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1210] Flake8 code validation Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1210] Added check, that pool works after view_change Signed-off-by: Andrew Nikitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.