Downgraded severity of some messages from debug to trace #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhoroshavin
force-pushed
the
reduce-logs
branch
from
747d64e to
7c08923
Compare
plenum/server/node.py
Outdated
| @@ -1764,8 +1764,8 @@ def preLedgerCatchUp(self, ledger_id): | |||
|
|
|||
| # revert uncommitted txns and state for unordered requests | |||
| r = self.master_replica.revert_unordered_batches() | |||
| logger.info('{} reverted {} batches before starting catch up for ' | |||
| 'ledger {}'.format(self, r, ledger_id)) | |||
| logger.trace('{} reverted {} batches before starting catch up for ' | |||
There was a problem hiding this comment.
I think this is quite important, and not so common (only called before catchup, and each catchup requires attention).
I think it should have DEBUG level.
skhoroshavin
force-pushed
the
reduce-logs
branch
from
7c08923 to
3b6fdec
Compare
stp_core/loop/looper.py
Outdated
| @@ -122,7 +122,7 @@ def __init__(self, | |||
|
|
|||
| for sigName in self.signals: | |||
| try: | |||
| logger.debug("Setting handler for {}".format(sigName)) | |||
| logger.trace("Setting handler for {}".format(sigName)) | |||
There was a problem hiding this comment.
It must be at least DEBUG
| @@ -745,7 +745,7 @@ def create3PCBatch(self, ledger_id): | |||
| rv = self.execute_hook(ReplicaHooks.CREATE_PPR, pre_prepare) | |||
| pre_prepare = rv if rv is not None else pre_prepare | |||
|
|
|||
| self.logger.debug('{} created a PRE-PREPARE with {} requests for ledger {}'.format( | |||
| self.logger.trace('{} created a PRE-PREPARE with {} requests for ledger {}'.format( | |||
There was a problem hiding this comment.
Do we have other DEBUG level entries where we log creation of a PRE-PREPARE by a Primary?
There was a problem hiding this comment.
We have at least sends for any message logged, is it enough?
Signed-off-by: Sergey Khoroshavin <[email protected]>
skhoroshavin
force-pushed
the
reduce-logs
branch
from
3b6fdec to
b7aed4e
Compare
ashcherbakov
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Khoroshavin [email protected]