[INDY-1138] Added get_equal_or_prev into parent class #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 14, 2018 17:21
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
| @@ -23,3 +23,22 @@ def compare(a, b): | |||
| def open(self): | |||
| self._db = leveldb.LevelDB(self.db_path, comparator=( | |||
| 'IntegerComparator', self.compare)) | |||
|
|
|||
| def get_equal_or_prev(self, key): | |||
There was a problem hiding this comment.
Please add tests for this
storage/kv_store.py
Outdated
| @@ -75,5 +75,8 @@ def _has_key(self, key): | |||
| except KeyError: | |||
| return False | |||
|
|
|||
| def get_equal_or_prev(self, key): | |||
| pass | |||
There was a problem hiding this comment.
I think it's better to either make it @AbstractMethod or raise NotImplementedException by default
Signed-off-by: Andrew Nikitin <[email protected]>
lampkin-diet
changed the title
| return storage, ts_list | ||
|
|
||
|
|
||
| def test_none_if_key_less_then_minimal_key(storage_with_ts_root_hashes): |
There was a problem hiding this comment.
We may consider having the same tests for RocksDB implementation as well (adding parameters to the tests), but I think it can be done with RocksDB support.
storage/kv_store.py
Outdated
| @@ -75,5 +75,8 @@ def _has_key(self, key): | |||
| except KeyError: | |||
| return False | |||
|
|
|||
| def get_equal_or_prev(self, key): | |||
| raise NotImplemented() | |||
There was a problem hiding this comment.
I think it needs to be NotImplementedError
Signed-off-by: Andrew Nikitin <[email protected]>
ashcherbakov
approved these changes
Mar 14, 2018
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
* [INDY-1138] Added get_equal_or_prev into KeyValue storages Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1138] Added abstract method for get_equal_or_prev Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1138] Remove @AbstractMethod decorator Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1138] Move test for storage from indy-node Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1138] Fix NotImplemented raise Signed-off-by: Andrew Nikitin <[email protected]>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
* [INDY-1138] Added get_equal_or_prev into KeyValue storages Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1138] Added abstract method for get_equal_or_prev Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1138] Remove @AbstractMethod decorator Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1138] Move test for storage from indy-node Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1138] Fix NotImplemented raise Signed-off-by: Andrew Nikitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.