Context manager for delay rules in stasher #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 12, 2018 18:27
Signed-off-by: Sergey Khoroshavin <[email protected]>
Signed-off-by: Sergey Khoroshavin <[email protected]>
Signed-off-by: Sergey Khoroshavin <[email protected]>
Signed-off-by: Sergey Khoroshavin <[email protected]>
Signed-off-by: Sergey Khoroshavin <[email protected]>
Signed-off-by: Sergey Khoroshavin <[email protected]>
ashcherbakov
approved these changes
Mar 13, 2018
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
* Refactored test_delay in test_stasher Signed-off-by: Sergey Khoroshavin <[email protected]> * Initial broken implementation of stasher delay_rules context Signed-off-by: Sergey Khoroshavin <[email protected]> * Possibly breaking changes in Stasher to fix context manager tests Signed-off-by: Sergey Khoroshavin <[email protected]> * Documented changes in stasher Signed-off-by: Sergey Khoroshavin <[email protected]> * Improved delay_rules implementation Signed-off-by: Sergey Khoroshavin <[email protected]> * Example use of new delay_rules context manager + misc cleanups Signed-off-by: Sergey Khoroshavin <[email protected]>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
* Refactored test_delay in test_stasher Signed-off-by: Sergey Khoroshavin <[email protected]> * Initial broken implementation of stasher delay_rules context Signed-off-by: Sergey Khoroshavin <[email protected]> * Possibly breaking changes in Stasher to fix context manager tests Signed-off-by: Sergey Khoroshavin <[email protected]> * Documented changes in stasher Signed-off-by: Sergey Khoroshavin <[email protected]> * Improved delay_rules implementation Signed-off-by: Sergey Khoroshavin <[email protected]> * Example use of new delay_rules context manager + misc cleanups Signed-off-by: Sergey Khoroshavin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
delay_rulescontext manager to simplify delay rules management in testsdelay_rulescontext managerOverall this new context manager should help write less error prone and more deterministic integration tests.