INDY-1148 : change test for validation nodes txns #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… - add dynamic validation of alias and test Signed-off-by: toktar <[email protected]>
… - put alias validation into PoolRequestHandler.isNodeDataConflicting Signed-off-by: toktar <[email protected]>
… - change validation in pool_req_handler. Signed-off-by: toktar <[email protected]>
…nto bugfix-1148-unique-alias
…nto bugfix-1148-unique-alias
…nto bugfix-1148-unique-alias
-deleted test_node_adding.py -test test_add_node_with_not_unique_alias move to test_nodes_with_pool_txns.py Signed-off-by: toktar <[email protected]>
|
Could one of the committers please verify this patch? |
-move test test_add_node_with_not_unique_alias to the end of test_nodes_with_pool_txns.py Signed-off-by: toktar <[email protected]>
spivachuk
approved these changes
Mar 6, 2018
ashcherbakov
approved these changes
Mar 6, 2018
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
* INDY-1148 - It's possible to create several nodes with the same alias - add dynamic validation of alias and test Signed-off-by: toktar <[email protected]> * INDY-1148 - It's possible to create several nodes with the same alias - put alias validation into PoolRequestHandler.isNodeDataConflicting Signed-off-by: toktar <[email protected]> * INDY-1148 - It's possible to create several nodes with the same alias - change validation in pool_req_handler. Signed-off-by: toktar <[email protected]> * INDY-1148 : change test for validation nodes -deleted test_node_adding.py -test test_add_node_with_not_unique_alias move to test_nodes_with_pool_txns.py Signed-off-by: toktar <[email protected]> * INDY-1148 : move test for validate node alias -move test test_add_node_with_not_unique_alias to the end of test_nodes_with_pool_txns.py Signed-off-by: toktar <[email protected]>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
* INDY-1148 - It's possible to create several nodes with the same alias - add dynamic validation of alias and test Signed-off-by: toktar <[email protected]> * INDY-1148 - It's possible to create several nodes with the same alias - put alias validation into PoolRequestHandler.isNodeDataConflicting Signed-off-by: toktar <[email protected]> * INDY-1148 - It's possible to create several nodes with the same alias - change validation in pool_req_handler. Signed-off-by: toktar <[email protected]> * INDY-1148 : change test for validation nodes -deleted test_node_adding.py -test test_add_node_with_not_unique_alias move to test_nodes_with_pool_txns.py Signed-off-by: toktar <[email protected]> * INDY-1148 : move test for validate node alias -move test test_add_node_with_not_unique_alias to the end of test_nodes_with_pool_txns.py Signed-off-by: toktar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-deleted test_node_adding.py
-test test_add_node_with_not_unique_alias migrate to indy sdk
-test test_add_node_with_not_unique_alias move to test_nodes_with_pool_txns.py