[INDY-1148] It's possible to create several nodes with the same alias #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Could one of the committers please verify this patch? |
|
Test this please |
spivachuk
suggested changes
Mar 5, 2018
plenum/server/pool_req_handler.py
Outdated
| curNodeData = self.stateSerializer.deserialize(curNodeData) | ||
| if nodeAlias == curNodeData.get( | ||
| ALIAS) and nodeNym.encode() != curNodeNym: | ||
| return "Alias " + curNodeData.get(ALIAS) + " already exists" |
There was a problem hiding this comment.
This logic should be put into PoolRequestHandler.isNodeDataConflicting method.
Toktar
force-pushed
the
bugfix-1148-unique-alias
branch
from
60e397c to
42e62d2
Compare
|
Test this please |
spivachuk
reviewed
Mar 5, 2018
plenum/server/pool_req_handler.py
Outdated
| @@ -80,7 +80,8 @@ def authErrorWhileAddingNode(self, request): | |||
| origin) | |||
| if self.stewardHasNode(origin): | |||
| return "{} already has a node".format(origin) | |||
| if self.isNodeDataConflicting(operation.get(DATA, {})): | |||
| if self.isNodeDataConflicting( | |||
| operation.get(DATA, request.operation.get(TARGET_NYM))): | |||
There was a problem hiding this comment.
What is the reason for this change?
… - add dynamic validation of alias and test Signed-off-by: toktar <[email protected]>
… - put alias validation into PoolRequestHandler.isNodeDataConflicting Signed-off-by: toktar <[email protected]>
… - change validation in pool_req_handler. Signed-off-by: toktar <[email protected]>
Toktar
force-pushed
the
bugfix-1148-unique-alias
branch
from
dcdf496 to
366ca07
Compare
|
test this please |
Toktar
changed the title
Toktar
changed the title
spivachuk
approved these changes
Mar 5, 2018
andkononykhin
approved these changes
Mar 5, 2018
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
…hyperledger#554) add dynamic validation of alias and test Signed-off-by: toktar <[email protected]> put alias validation into PoolRequestHandler.isNodeDataConflicting Signed-off-by: toktar <[email protected]> change validation in pool_req_handler. Signed-off-by: toktar <[email protected]>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
…hyperledger#554) add dynamic validation of alias and test Signed-off-by: toktar <[email protected]> put alias validation into PoolRequestHandler.isNodeDataConflicting Signed-off-by: toktar <[email protected]> change validation in pool_req_handler. Signed-off-by: toktar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dynamic validation of alias and test
Signed-off-by: toktar [email protected]