INDY-1113: Node disconnection, view change tests #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spivachuk
commented
Feb 26, 2018
•
spivachuk
commented
- Corrected the procedures of node disconnection and reconnection in tests.
- Removed a workaround patch which had become unnecessary from start_stopped_node function in tests.
- Corrected existing tests according to the fixes specified above.
- Added a test verifying that a view change is restarted each time when the previous one is timed out.
- Added a test verifying that a disconnected node with a lagged view accepts the current view from the other nodes on re-connection.
- Fixed the cause of a potential error with a not retrieved exception of a future in sdk_get_replies function.
- Corrected test helpers for Indy SDK.
- Added a workaround to avoid hang-ups of test_6_nodes_pool_cannot_reach_quorum_with_2_disconnected.
Add new method getNodesServices (hyperledger#506)
- Corrected the procedures of node disconnection and reconnection in tests. - Removed a workaround patch which had become unnecessary from start_stopped_node function in tests. - Corrected existing tests according to the fixes specified above. - Added a test verifying that a view change is restarted each time when the previous one is timed out. - Added a test verifying that a disconnected node with a lagged view accepts the current view from the other nodes on re-connection. Signed-off-by: Nikita Spivachuk <[email protected]>
…e-disconnection-fix Signed-off-by: Nikita Spivachuk <[email protected]> # Conflicts: # plenum/test/node_request/test_quorum_disconnected.py # plenum/test/pool_transactions/helper.py # plenum/test/test_stack.py
|
Could one of the committers please verify this patch? |
|
test this please |
ashcherbakov
requested changes
Feb 27, 2018
plenum/test/helper.py
Outdated
| vNo, = viewNos | ||
| if expectedViewNo is not None: | ||
| assert vNo >= expectedViewNo, ','.join(['{} -> Ratio: {}'.format( | ||
| node.name, node.monitor.masterThroughputRatio()) for node in nodes]) | ||
| assert vNo == expectedViewNo, 'Expected {}, but got {}'.format(expectedViewNo, vNo) |
There was a problem hiding this comment.
It must be >=, since there may be more than one view change.
| @@ -540,7 +541,8 @@ def new_client(looper, poolTxnClientData, txnPoolNodeSet, client_tdir): | |||
| return client, wallet | |||
|
|
|||
|
|
|||
| def disconnectPoolNode(poolNodes: Iterable, | |||
| def disconnectPoolNode(looper: Looper, | |||
There was a problem hiding this comment.
Why do we need looper here?
- Returned back the not strict view number comparison in checkViewNoForNodes function in tests since the strict comparison may cause failures of some tests. - Corrected parameter lists of some test helper functions. Signed-off-by: Nikita Spivachuk <[email protected]>
- Fixed the cause of a potential error with a not retrieved exception of a future in sdk_get_replies function. - Corrected test helpers for Indy SDK. Signed-off-by: Nikita Spivachuk <[email protected]>
- Added a workaround to avoid hang-ups of test_6_nodes_pool_cannot_reach_quorum_with_2_disconnected. Signed-off-by: Nikita Spivachuk <[email protected]>
Signed-off-by: Nikita Spivachuk <[email protected]>
|
test this please |
ashcherbakov
approved these changes
Mar 5, 2018
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
* INDY-1113: Node disconnection, view change tests - Corrected the procedures of node disconnection and reconnection in tests. - Removed a workaround patch which had become unnecessary from start_stopped_node function in tests. - Corrected existing tests according to the fixes specified above. - Added a test verifying that a view change is restarted each time when the previous one is timed out. - Added a test verifying that a disconnected node with a lagged view accepts the current view from the other nodes on re-connection. Signed-off-by: Nikita Spivachuk <[email protected]> * INDY-1113: Return not strict view no comparison - Returned back the not strict view number comparison in checkViewNoForNodes function in tests since the strict comparison may cause failures of some tests. - Corrected parameter lists of some test helper functions. Signed-off-by: Nikita Spivachuk <[email protected]> * INDY-1113: Fixed error with future - Fixed the cause of a potential error with a not retrieved exception of a future in sdk_get_replies function. - Corrected test helpers for Indy SDK. Signed-off-by: Nikita Spivachuk <[email protected]> * INDY-1113: Avoided test hang-ups - Added a workaround to avoid hang-ups of test_6_nodes_pool_cannot_reach_quorum_with_2_disconnected. Signed-off-by: Nikita Spivachuk <[email protected]> * INDY-1113: Corrected a test Signed-off-by: Nikita Spivachuk <[email protected]>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
* INDY-1113: Node disconnection, view change tests - Corrected the procedures of node disconnection and reconnection in tests. - Removed a workaround patch which had become unnecessary from start_stopped_node function in tests. - Corrected existing tests according to the fixes specified above. - Added a test verifying that a view change is restarted each time when the previous one is timed out. - Added a test verifying that a disconnected node with a lagged view accepts the current view from the other nodes on re-connection. Signed-off-by: Nikita Spivachuk <[email protected]> * INDY-1113: Return not strict view no comparison - Returned back the not strict view number comparison in checkViewNoForNodes function in tests since the strict comparison may cause failures of some tests. - Corrected parameter lists of some test helper functions. Signed-off-by: Nikita Spivachuk <[email protected]> * INDY-1113: Fixed error with future - Fixed the cause of a potential error with a not retrieved exception of a future in sdk_get_replies function. - Corrected test helpers for Indy SDK. Signed-off-by: Nikita Spivachuk <[email protected]> * INDY-1113: Avoided test hang-ups - Added a workaround to avoid hang-ups of test_6_nodes_pool_cannot_reach_quorum_with_2_disconnected. Signed-off-by: Nikita Spivachuk <[email protected]> * INDY-1113: Corrected a test Signed-off-by: Nikita Spivachuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.