Updates to handle recursive structures in swagger - depends on kin-openapi change #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kin-openapi change Signed-off-by: Peter Broadhurst <[email protected]>
|
Looks like upstream PR has been merged 🥳 |
Signed-off-by: Andrew Richardson <[email protected]>
awrichar
reviewed
Dec 2, 2021
| @@ -31,7 +31,7 @@ import ( | |||
| ) | |||
|
|
|||
| func newSubscriptionSchemaGenerator(ctx context.Context) string { | |||
| baseSchema, _, _ := openapi3gen.NewSchemaRefForValue(&fftypes.Subscription{}) | |||
| baseSchema, _ := openapi3gen.NewSchemaRefForValue(&fftypes.Subscription{}, nil) | |||
There was a problem hiding this comment.
Is there any issue with passing nil here? @peterbroadhurst
There was a problem hiding this comment.
Think that's fine - would only be a problem if we ever introduce a recursive schema into one of the subscription types 👍
awrichar
approved these changes
Dec 2, 2021
awrichar
added a commit
to kaleido-io/firefly
that referenced
this pull request
Dec 2, 2021
Coverage for JSONInputMask was inadvertently lost. Signed-off-by: Andrew Richardson <[email protected]>
awrichar
added a commit
that referenced
this pull request
Dec 2, 2021
Coverage for JSONInputMask was inadvertently lost. Signed-off-by: Andrew Richardson <[email protected]>
awrichar
added a commit
to kaleido-io/firefly
that referenced
this pull request
Dec 10, 2021
Coverage for JSONInputMask was inadvertently lost. Signed-off-by: Andrew Richardson <[email protected]>
awrichar
added a commit
to kaleido-io/firefly
that referenced
this pull request
Dec 13, 2021
Coverage for JSONInputMask was inadvertently lost. Signed-off-by: Andrew Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.modreplace stripping out before it can move out of draftffenumetc. tags on outputs (only inputs)