Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/tokens/accounts returns null when no accounts are in the network #345

Closed
dechdev opened this issue Dec 2, 2021 · 0 comments · Fixed by #346
Closed

/tokens/accounts returns null when no accounts are in the network #345

dechdev opened this issue Dec 2, 2021 · 0 comments · Fixed by #346

Comments

@dechdev
Copy link
Contributor

dechdev commented Dec 2, 2021

When sending a GET request to /tokens/accounts on a firefly network with no accounts, the response is null rather than an expected response of []

Steps to reproduce:

  1. Start-up firefly org with no accounts in DB
  2. Send GET request to /tokens/accounts
  3. Response is null. Expected response is []
awrichar added a commit to kaleido-io/firefly that referenced this issue Dec 2, 2021
@awrichar
Return an empty slice (rather than nil) for zero token accounts
29d2171 
Fixes hyperledger#345

Signed-off-by: Andrew Richardson <[email protected]>
@awrichar awrichar mentioned this issue Dec 2, 2021
Merged
awrichar added a commit that referenced this issue Dec 2, 2021
@awrichar
Return an empty slice (rather than nil) for zero token accounts
d3d1fbf 
Fixes #345

Signed-off-by: Andrew Richardson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return an empty slice (rather than nil) for zero token accounts kaleido-io/firefly
1 participant
@dechdev