escape special charecters that can be set through the command line ar… #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guments Signed-off-by: Rohan Shrothrium <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Close and Re-open to trigger CI. |
|
This PR causes a legitimate test failure in cmd/fabric-ca-server/main_test.go unit test TestErrors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…guments
Signed-off-by: Rohan Shrothrium [email protected]
Type of change
Description
When we initialise a fabric ca server with an admin and adminpw, if they have special characters the ca behaves not as expected.
These special characters can be in anything that can be passed through the command line arguments.
This PR is meant to escape these special characters in the
ymlfile.