feat(cactus-plugin-ledger-connector-fabric-socketio): remove fabric-socketio connector #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic Private Key | 50f6ce5 | packages/cactus-plugin-ledger-connector-fabric-socketio/src/test/typescript/unit-test/validatorDriver_signTransactionOffline.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Sep 28, 2023
…nector
- Refactor discounted asset trade sample to use openapi ethereum connector instead
of ethereum-socketio.
- Sample still uses offline signing from cmd-socketio-server
Depends on: hyperledger-cacti#2645
|
This PR/issue depends on:
|
…ocketio connector
- Remove cactus-plugin-ledger-connector-fabric-socketio connector.
- Refactor discounted cartrade sample to use openapi fabric connector instead of fabric-socketio.
Sample app will use delegated signing, similar to offline signing in old connector.
- Remove dead code from cmd-socketio-server
- Update fabric SDK to 2.X in all cacti projects, refactor code that use it where necessary.
Only exception is fabric persistence plugin which uses fabric SDK as dev dependency (for tests).
It can be updated in separate PR later on.
Depends on: hyperledger-cacti#2644
Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
remove_fabric_connector_pr
branch
from
51af952
to
50f6ce5
Compare
petermetz
approved these changes
Oct 12, 2023
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Oct 17, 2023
…nector
- Refactor discounted asset trade sample to use openapi ethereum connector
instead of ethereum-socketio.
- Use eth signing utils from ethereum connector package.
- Fix nodejs setup in indy-sdk-cli docker image.
- Small fixes after recent ethereum connector refactors.
Depends on: hyperledger-cacti#2645
Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Oct 17, 2023
…nector
- Refactor discounted asset trade sample to use openapi ethereum connector
instead of ethereum-socketio.
- Use eth signing utils from ethereum connector package.
- Fix nodejs setup in indy-sdk-cli docker image.
- Small fixes after recent ethereum connector refactors.
Depends on: hyperledger-cacti#2645
Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
that referenced
this pull request
Oct 17, 2023
…nector
- Refactor discounted asset trade sample to use openapi ethereum connector
instead of ethereum-socketio.
- Use eth signing utils from ethereum connector package.
- Fix nodejs setup in indy-sdk-cli docker image.
- Small fixes after recent ethereum connector refactors.
Depends on: #2645
Signed-off-by: Michal Bajer <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
…nector
- Refactor discounted asset trade sample to use openapi ethereum connector
instead of ethereum-socketio.
- Use eth signing utils from ethereum connector package.
- Fix nodejs setup in indy-sdk-cli docker image.
- Small fixes after recent ethereum connector refactors.
Depends on: hyperledger-cacti#2645
Signed-off-by: Michal Bajer <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample app will use delegated signing, similar to offline signing in old connector.
Only exception is fabric persistence plugin which uses fabric SDK as dev dependency (for tests).
It can be updated in separate PR later on.
Depends on #2644
Closes #302
Signed-off-by: Michal Bajer [email protected]