Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-example-discounted-asset-trade): use openapi ethereum connector #2723

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Sep 28, 2023

  • Refactor discounted asset trade sample to use openapi ethereum connector
    instead of ethereum-socketio.
  • Use eth signing utils from ethereum connector package.
  • Fix nodejs setup in indy-sdk-cli docker image.
  • Small fixes after recent ethereum connector refactors.

Depends on: #2645

Signed-off-by: Michal Bajer [email protected]

@gitguardian
Copy link

gitguardian bot commented Sep 28, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH There's only one parent PR but 4 commits. Does this need a rebase + squash?
The one commit that matches the PR title is looking good otherwise.

@outSH
Copy link
Contributor Author

outSH commented Sep 29, 2023

@outSH There's only one parent PR but 4 commits. Does this need a rebase + squash? The one commit that matches the PR title is looking good otherwise.

@petermetz These are commits from dependencies of the dependency

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz
Copy link
Contributor

@outSH There's only one parent PR but 4 commits. Does this need a rebase + squash? The one commit that matches the PR title is looking good otherwise.

@petermetz These are commits from dependencies of the dependency

@outSH /facepalm - sorry, I should've known/checked/etc.

@petermetz petermetz self-requested a review October 5, 2023 21:31
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Looks good but please pass it back for review once the parent PR(s) have been merged and the conflicts have been resolved! (I'm just marking it down as a change request to not forget that I have to take a second pass on it once it reached it's final state)

@outSH outSH force-pushed the use_openapi_ethereum_in_discounted_asset_trade branch from 5e45a2d to d6aa5a1 Compare October 17, 2023 11:21
@outSH
Copy link
Contributor Author

outSH commented Oct 17, 2023

pass it back for review once the parent PR(s) have been merged and the conflicts have been resolved

@petermetz
Done, I've also included the following changes:

  • Use eth signing utils from ethereum connector package.
  • Fix nodejs setup in indy-sdk-cli docker image.
  • Small fixes after recent ethereum connector refactors.

@outSH outSH requested a review from petermetz October 17, 2023 11:23
…nector

- Refactor discounted asset trade sample to use openapi ethereum connector
    instead of ethereum-socketio.
- Use eth signing utils from ethereum connector package.
- Fix nodejs setup in indy-sdk-cli docker image.
- Small fixes after recent ethereum connector refactors.

Depends on: hyperledger-cacti#2645

Signed-off-by: Michal Bajer <[email protected]>
@petermetz petermetz force-pushed the use_openapi_ethereum_in_discounted_asset_trade branch from d6aa5a1 to 3b48876 Compare October 17, 2023 17:50
@petermetz petermetz enabled auto-merge (rebase) October 17, 2023 17:50
@petermetz
Copy link
Contributor

pass it back for review once the parent PR(s) have been merged and the conflicts have been resolved

@petermetz Done, I've also included the following changes:

* Use eth signing utils from ethereum connector package.

* Fix nodejs setup in indy-sdk-cli docker image.

* Small fixes after recent ethereum connector refactors.

@outSH Gotcha, LGTM, thank you for the updates!

@petermetz petermetz merged commit dcaf9fe into hyperledger-cacti:main Oct 17, 2023
48 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants