Skip to content

remove remaining 4 deprecated CLI options #9385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
macfarla merged 7 commits into from
Nov 2, 2025
Merged

remove remaining 4 deprecated CLI options #9385

macfarla merged 7 commits into from
Nov 2, 2025

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Oct 31, 2025 •
edited
Loading

Signed-off-by: Sally MacFarlane [email protected]## PR description

Fixed Issue(s)

  • Remove these deprecated CLI options
    • Remove--Xbonsai-parallel-tx-processing-enabled deprecated since 25.7.0. Use --bonsai-parallel-tx-processing-enabled instead.
    • Remove --Xsnapsync-server-enabled deprecated since 25.7.0. Use --snapsync-server-enabled instead.
    • Remove --Xsnapsync-synchronizer-pre-merge-headers-only-enabled deprecated since 25.7.0. Use --snapsync-synchronizer-pre-checkpoint-headers-only-enabled instead.
    • Remove --Xhistory-expiry-prune deprecated since 25.7.0. Use --history-expiry-prune instead.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@macfarla macfarla added the breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. label Oct 31, 2025
@macfarla
changelog pr number
69cf2f9 
Signed-off-by: Sally MacFarlane <[email protected]>
siladu
siladu approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@macfarla macfarla enabled auto-merge (squash) November 2, 2025 22:52
@macfarla macfarla merged commit ea3db7f into hyperledger:main Nov 2, 2025
46 checks passed
@macfarla macfarla deleted the remove-deprecated-options branch November 3, 2025 00:51
@macfarla macfarla mentioned this pull request Nov 4, 2025
Merged
danceratopz added a commit to ethereum/hive that referenced this pull request Nov 4, 2025
@danceratopz
clients/besu: update name of snap sync flag (#1368)
f9c91b6 
replace use of deprecated CLI option name with the new one
`--Xsnapsync-server-enabled` removed in besu
hyperledger/besu#9385
jflo pushed a commit to jflo/besu that referenced this pull request Nov 17, 2025
@macfarla @jflo
remove remaining 4 deprecated CLI options (hyperledger#9385)
d9ae84e 
* remove 4 deprecated CLI options

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
@theomart77
Copy link

theomart77 commented Dec 12, 2025

Signed-off-by: Sally MacFarlane [email protected]## PR description

Fixed Issue(s)

  • Remove these deprecated CLI options
    • Remove--Xbonsai-parallel-tx-processing-enabled deprecated since 25.7.0. Use --bonsai-parallel-tx-processing-enabled instead.
    • Remove --Xsnapsync-server-enabled deprecated since 25.7.0. Use --snapsync-server-enabled instead.
    • Remove --Xsnapsync-synchronizer-pre-merge-headers-only-enabled deprecated since 25.7.0. Use --snapsync-synchronizer-pre-checkpoint-headers-only-enabled instead.
    • Remove --Xhistory-expiry-prune deprecated since 25.7.0. Use --history-expiry-prune instead.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

pinges pushed a commit to pinges/besu that referenced this pull request Dec 15, 2025
@macfarla @pinges
remove remaining 4 deprecated CLI options (hyperledger#9385)
7bc382f 
* remove 4 deprecated CLI options

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jframe jframe jframe approved these changes

@siladu siladu siladu approved these changes

Assignees

No one assigned

Labels

breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@macfarla @theomart77 @jframe @siladu