Make logic in PersistBlockTask more explicit to fix a LGTM warning #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d generally make the code more readable. Signed-off-by: Adrian Sutton <[email protected]>
|
This pull request fixes 2 alerts when merging a729d8f into 7052982 - view on LGTM.com fixed alerts:
|
CjHare
approved these changes
Oct 8, 2019
| @@ -67,22 +68,20 @@ private PersistBlockTask( | |||
| final List<Block> blocks, | |||
| final HeaderValidationMode headerValidationMode, | |||
| final MetricsSystem metricsSystem) { | |||
| checkArgument(blocks.size() > 0); | |||
| checkArgument(!blocks.isEmpty()); | |||
There was a problem hiding this comment.
nit; adding an error message to the checkArgument would make an quicker to understand error condition
Signed-off-by: Adrian Sutton <[email protected]>
|
This pull request fixes 2 alerts when merging c17affe into 13ae431 - view on LGTM.com fixed alerts:
|
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Nov 4, 2019
…yperledger#92) Signed-off-by: Adrian Sutton <[email protected]> Signed-off-by: edwardmack <[email protected]>
edwardmack
added a commit
to ChainSafe/besu
that referenced
this pull request
Nov 6, 2019
commit 1ae36198d684e727cad224cbc56c9f16a3bc3b65 Author: edwardmack <[email protected]> Date: Wed Nov 6 10:13:09 2019 -0500 Address PR Comments, organize code Signed-off-by: edwardmack <[email protected]> commit e5151c3b8ac5bf0cd64e6b8f298c88c5f3476101 Author: edwardmack <[email protected]> Date: Tue Nov 5 16:26:25 2019 -0500 merge branch Signed-off-by: edwardmack <[email protected]> commit 17ef8010392d622e4be928ccb7eb0f1451750ea2 Author: edwardmack <[email protected]> Date: Tue Nov 5 16:21:44 2019 -0500 Merge branch Signed-off-by: edwardmack <[email protected]> commit b4e79d27d6a165f6d57121ccf7c0c71c57685a7b Merge: d1cdfeb92 235a7cdb6 Author: Edward Mack <[email protected]> Date: Tue Nov 5 14:00:21 2019 -0500 Merge branch 'master' into greg/backport-3 commit d1cdfeb92bb958a9918254096e8990120f3b5147 Merge: 9e481da6f 3bda75afd Author: edwardmack <[email protected]> Date: Tue Nov 5 12:13:46 2019 -0500 Merge branch 'greg/backport-3' of https://github.com/chainsafe/besu into greg/backport-3 Signed-off-by: edwardmack <[email protected]> commit 235a7cdb6f6d2025cc1cd1cec251ba6667a00b3e Author: Ratan Rai Sur <[email protected]> Date: Tue Nov 5 13:30:59 2019 -0500 remove outdated comment (#161) Signed-off-by: Ratan Rai Sur <[email protected]> commit 3bda75afdb230e14448c5c2db36a05e0a0235af2 Merge: bd944e2bf 386053a9d Author: Edward Mack <[email protected]> Date: Tue Nov 5 11:07:26 2019 -0500 Merge branch 'master' into greg/backport-3 Signed-off-by: edwardmack <[email protected]> Signed-off-by: Gregory Markou <[email protected]> commit 9e481da6fcaf7889a0991f70a67ffa53ba2a03a0 Merge: bd944e2bf 386053a9d Author: Edward Mack <[email protected]> Date: Tue Nov 5 11:07:26 2019 -0500 Merge branch 'master' into greg/backport-3 Signed-off-by: edwardmack <[email protected]> commit bd944e2bfa10d12ca160d1e00e766a78ee909a50 Author: edwardmack <[email protected]> Date: Tue Nov 5 11:05:59 2019 -0500 Address PR comments Refactored code to match suggestions from PR review. commit 386053a9dd6eb14b5a6284175b26e8634818fd3a Author: CJ Hare <[email protected]> Date: Tue Nov 5 16:27:24 2019 +1000 Redesign of how JsonRpcMethods are created (#159) Signed-off-by: Christopher Hare <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> commit b6597309641f4aff1cad20936a9b7b17d44ef73d Author: Joshua Fernandes <[email protected]> Date: Tue Nov 5 11:38:20 2019 +1000 commenting out circles publish on the release branch so we're ready for the release tomorrow and dont have jenkins & circle attempting to publish (#157) Signed-off-by: Joshua Fernandes <[email protected]> commit 7e2497bf95a5673faeba439bf5da2be4b6361d5b Author: Ratan Rai Sur <[email protected]> Date: Mon Nov 4 16:55:58 2019 -0500 [PAN-2798] Enable pruning by default for fast sync (#135) Signed-off-by: Ratan Rai Sur <[email protected]> commit 1b6400e7b3124456772a5f732244b583eb37d71c Merge: efe7cbb49 72e975e8e Author: Gregory Markou <[email protected]> Date: Mon Nov 4 11:24:28 2019 -0500 Merge branch 'master' into greg/backport-3 commit efe7cbb493abb599a0d660374b296fb0186c3513 Author: Danno Ferrin <[email protected]> Date: Mon Nov 4 08:08:49 2019 -0700 Add --identity flag for client identification in node browsers (#150) Support the "--identity" flag. This adds a fifth field to the normally four part clientId, with the identity in the second position. For example, if the CLI flag "--identity PegaSysEng" were passed in the clientID reported by ethernodes would read `besu/PegaSysEng/v1.3.2/linux-x86_64/oracle_openjdk-java-11` Whereas without the flag it would just read `besu/v1.3.2/linux-x86_64/oracle_openjdk-java-11` Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit f00f03cbbb0a8c4febaf5835e721b32418d1ed3a Author: CJ Hare <[email protected]> Date: Mon Nov 4 17:21:07 2019 +1000 Moving JsonRpcMethods classes into the same package, prior to refactor (#154) Signed-off-by: Christopher Hare <[email protected]> Signed-off-by: edwardmack <[email protected]> commit a852f3f871727c18347c0c24bb8f44d1d510dfa7 Author: Sally MacFarlane <[email protected]> Date: Mon Nov 4 11:14:20 2019 +1000 edits to test names (#153) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 4a22b6a541dd3900d5bb8bf881d8016316647798 Author: edwardmack <[email protected]> Date: Thu Oct 17 18:23:51 2019 -0400 Added protocol spec for DieHard fork Added code to create protocol definition for changes made for the DieHard fork Signed-off-by: edwardmack <[email protected]> commit 8a2add898f2b7386ba8bf745f6ffd799dd333541 Author: edwardmack <[email protected]> Date: Tue Oct 15 10:26:49 2019 -0400 Code for ECIP-1015 on Classic network Added code to handle the Ethereum Classic Gas Reprice ECIP-1015. Signed-off-by: edwardmack <[email protected]> commit 771a47456f7a641e04e38b7a09f91e9cf61b64c5 Author: edwardmack <[email protected]> Date: Mon Oct 14 10:13:26 2019 -0400 Added Defuse Difficulty Bomb code Added code to conform to ECIP-1041 to defuse the difficulty bomb. Signed-off-by: edwardmack <[email protected]> commit f68bf33e4c9e1f18e09cb5782f88e274588231de Author: edwardmack <[email protected]> Date: Mon Oct 14 09:50:55 2019 -0400 Added network config for Kotti test network Added kotti.json genesis config file, and added enodes list for kotti test network. Can now test on kotti testnet using --network=kotti Signed-off-by: edwardmack <[email protected]> commit 33770eab498d543c305d12353c1d1941fcfedcee Author: edwardmack <[email protected]> Date: Mon Oct 14 09:24:39 2019 -0400 Create ClassicProtocolSpecs class Created class ClassicProtocolSpecs to contain spec definitions specific to the classic network. Signed-off-by: edwardmack <[email protected]> commit d2a1ce8be0542b214eab34f5b284c1b80953504a Author: Trent Mohay <[email protected]> Date: Fri Nov 1 09:22:48 2019 +1100 Add IbftQueryService to Plugin-api The IbftQueryService has been added to the Plugin-api, along with an implementation. This allows IBFT specific aspects of a block header to be queried (round number, and signers in block). Signed-off-by: Trent Mohay <[email protected]> Signed-off-by: edwardmack <[email protected]> commit ebad591356296bf07ad3a7f9feddbdb3de195e7c Author: Danno Ferrin <[email protected]> Date: Thu Oct 31 13:19:41 2019 -0600 Istanbul Mainnet Block (#145) Istanbul Mainnet block is 9,069,000. Update mainnet config. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit db6e51980e3e2edfe5566dc3258965818929d951 Author: Danno Ferrin <[email protected]> Date: Thu Oct 31 12:27:56 2019 -0600 [PAN-3143] Handle zero port better in NAT (#147) When setting the p2p port to zero and turning on UPNP nat an attempt is made to map port zero. This should actually map the opened port instead. The core logic is also now set up to throw an exception if a zero local port is requested. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 8db4a95d66f3137e4209746aee739edee4a127e8 Author: Danno Ferrin <[email protected]> Date: Thu Oct 31 08:11:05 2019 -0600 [PAN-3262] Reflect default logging in help (#148) Instead of hard coding the default logging to info reflect the value from the LogManager. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 17e7dbfe2c8c8fb9e97dc818b13505dd34eecff1 Author: Joshua Fernandes <[email protected]> Date: Thu Oct 31 15:48:30 2019 +1000 adding in circle config (#143) * adding in circle config to publish artifacts * test results * pr fixes Signed-off-by: Joshua Fernandes <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 6cb99597482a57ec9e2ea5773b3f83d1a0865d18 Author: Ratan Rai Sur <[email protected]> Date: Wed Oct 30 17:34:45 2019 -0400 Rework how filter and log query parameters are created/used (#146) * Rework how filter and log query parameters are created/used We used a `FilterParameter` that held strings in places where we could create strongly typed objects. We also used it in places where we only wanted a subset of its descriptiveness, namely, the `LogsQuery` part of it. * deserialize directly into `LogsQuery`, which is useful for log pub/sub * narrow uses of `FilterParameter` to `LogsQuery` where possible * make `FilterParameter` hold strongly typed `Address`s and `LogTopic`s Signed-off-by: Ratan Rai Sur <[email protected]> Signed-off-by: edwardmack <[email protected]> commit fe64c61d676754eabd2d9aacf1fb73acce0d81ea Author: Usman Saleem <[email protected]> Date: Thu Oct 31 06:02:47 2019 +1000 Use gradle root project build dir in check-license (#144) Fixed check-license to use root project's build dir property instead of relative path which resolves to user.dir. Signed-off-by: Usman Saleem <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 7e7d97d16a1c268ad0b88fbb542519ead78d6ff4 Author: mbaxter <[email protected]> Date: Tue Oct 29 10:30:10 2019 -0400 [Refactor] Don't generate shutdown tasks in controller (#141) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit dcb85e65d2b8932c35c81a969b6b1ca46895977c Author: Kasper Ziemianek <[email protected]> Date: Tue Oct 29 01:32:27 2019 +0100 [PAN-2830] improve message when extraData missing (#121) Signed-off-by: Kasper Ziemianek <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 14ce164ef9d55b8d0e0abc190118c1a13f3c8e0e Author: mbaxter <[email protected]> Date: Mon Oct 28 15:53:13 2019 -0400 Fix miner startup logic (#104) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 338a21f1cc6067bd120302eb14d5d0544408cb72 Author: pinges <[email protected]> Date: Mon Oct 28 11:37:48 2019 +1000 Rename eea_getTransactionCount to priv_getEeaTransactionCount (#110) Rename eea_getTransactionCount to priv_getEeaTransactionCount Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Jason Frame <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 5137b2d7241208893f5759c270881f5da8badfbe Author: Tim Beiko <[email protected]> Date: Thu Oct 24 15:53:43 2019 -0400 Update ROADMAP.md (#136) Signed-off-by: Tim Beiko <[email protected]> Signed-off-by: edwardmack <[email protected]> commit ab28ce2ca9da0e5d946d5deb22a98d146a764df8 Author: Danno Ferrin <[email protected]> Date: Thu Oct 24 11:40:43 2019 -0600 [PAN-3249] Use Bloombits for Logs queries (#127) Use the bloombits for logs queries, so we only have to walk headers and not every receipt on a large query. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 9f40cabdad805994ded48f95bda060ffef2db9a8 Author: Ratan Rai Sur <[email protected]> Date: Thu Oct 24 11:23:37 2019 -0400 Support log reordring from reorgs in `LogSubscriptionService` (#86) Signed-off-by: Ratan Rai Sur <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 25f24bcc22abb2a551a862913769b18bac98e10b Author: Adrian Sutton <[email protected]> Date: Thu Oct 24 17:33:48 2019 +1000 Ensure spotless runs in CI (#132) Signed-off-by: Adrian Sutton <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 03e310322d4805866d8de14e67e5400099d3ecb5 Author: Trent Mohay <[email protected]> Date: Thu Oct 24 11:33:55 2019 +1100 Repair EthGetLogs returning incorrect results (#128) An error was detected (PAN-3248) whereby if "Null" appeared in a Log Topic filter, it and all subsequent filters were lost (and thus were not used to filter responses) - thus Besu would return too many results (as the filters were less restrictive than requested). This was determined to be an issue in the TopicParameterDeserialiser which is resolved in this commit. Signed-off-by: Trent Mohay <[email protected]> Signed-off-by: edwardmack <[email protected]> commit aaecf4c2e51daba6bee56797cd5506b50b8611e0 Author: mbaxter <[email protected]> Date: Wed Oct 23 13:32:55 2019 -0400 [Minor] Add more logging around peer disconnects (#131) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit ae73a73aac6cd2a09cac995402ab1e2a0d410121 Author: Edward <[email protected]> Date: Wed Oct 23 09:18:44 2019 +1000 Prepare for version 1.3.3-SNAPSHOT (#126) Signed-off-by: Edward Evans <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 3270f8e2e320621cd667b9c7079d5056330124e0 Author: MadelineMurray <[email protected]> Date: Wed Oct 23 08:48:48 2019 +1000 1.3.2 release (#125) Signed-off-by: Edward Evans <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 7530cad9b2c1cb2dcdf9a912fbf868b74d1014d0 Author: Usman Saleem <[email protected]> Date: Tue Oct 22 18:07:08 2019 +1000 [PIE-2052] Besu CLI -V to print plugin versions (#123) -- Use (PicoCLI) custom factory to construct version provider which can return optional plugin versions -- Use plugin's jar manifest implementation and version to build plugin version during plugin registration Signed-off-by: Usman Saleem <[email protected]> Signed-off-by: edwardmack <[email protected]> commit ada6f2342220ffd25246f1d0c016f89579824e9a Author: Danno Ferrin <[email protected]> Date: Mon Oct 21 22:30:09 2019 -0600 Update Governance and Code of Conduct verbiage. (#120) The old governance doc does not apply to the Hyperledger project, so it is deleted. Added a note that there is also a HLP code of conduct that also applies. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit b4777e0a2b19497480b2162b282a0eb4f8d51463 Author: Ivaylo Kirilov <[email protected]> Date: Mon Oct 21 09:48:17 2019 +0100 Fix state root mismatch when trying to modify public state from priv tx (#118) Signed-off-by: Ivaylo Kirilov <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 3cced79e49ea7552660aa5d61369cf552fb740f0 Author: CJ Hare <[email protected]> Date: Mon Oct 21 13:16:44 2019 +1000 Removing duplicate gradle dependency (#122) Signed-off-by: Christopher Hare <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 7c009816cd48d5808c60a9564e853edd8a2a380a Author: Danno Ferrin <[email protected]> Date: Thu Oct 17 16:21:52 2019 -0600 [PAN-3242] Programatically enforce plugin CLI variable names (#117) Enforce that plugin variable names are either `--plugin-<namespace>-` or `--Xplugin-<namespace>-` when registered with the PicoCLIOptionsService. If the names don't match a RuntimeException is thrown, and unless that exception is caught the plugin will not have start or stop lifecycle messages called. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 2ce5c5c1f5c586be439e0cfc7aad5c89f73317f8 Author: mbaxter <[email protected]> Date: Thu Oct 17 10:54:36 2019 -0400 Only set sync targets that have an estimated height value (#115) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit bbeb0db05d39354ce3209e2127e2da044c9ddc0b Author: mbaxter <[email protected]> Date: Thu Oct 17 10:53:23 2019 -0400 [Pan 3238] Fix rlpx startup (#114) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 3c9b90830bfb1172d46b5d3f4d18f8562291da47 Author: Danno Ferrin <[email protected]> Date: Thu Oct 17 07:36:02 2019 -0600 Update dependencies (#112) Upgrade dependencies except rocksdb (needs burn in testing), picocli (reorders options), gradle (causes build server breakage), and web3j (test failures). * Awaitality removed a Duration object and instead uses java.time * jackson stopped throwing a checked exception for one API * spotless now enforces gradle formatting checks (yea!) Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit b8db8aabd86234e9d83d8e21afb02058da850335 Author: Abdelhamid Bakhta <[email protected]> Date: Thu Oct 17 09:45:16 2019 +0200 Expose getPayload in Transaction plugin-api interface. (#113) * Expose getPayload in Transaction plugin-api interface. - added `getPayload` in `Transaction` plugin-api interface. - added `@Override` annotation in `Transaction` core object. - updated known hash of `plugin-api`. Signed-off-by: Abdelhamid Bakhta <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 8abbb750d9999aabfacc59fbdd484703461928b0 Author: Jason Frame <[email protected]> Date: Thu Oct 17 16:28:08 2019 +1000 Additional unit test for selecting replaced pending transactions (#116) * Additional unit test for selecting replaced pending transactions Signed-off-by: Jason Frame <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 92e09ce927ba14dbe228b5b3c1d5568d8332af6c Author: Abdelhamid Bakhta <[email protected]> Date: Wed Oct 16 18:46:12 2019 +0200 Add hash field in Transaction plugin interface. (#111) Add `hash` field in `Transaction` plugin interface. * - rename `hash` method to `getHash`. - update `plugin-api` known hash. Signed-off-by: Abdelhamid Bakhta <[email protected]> Signed-off-by: edwardmack <[email protected]> commit f5759d60fbb498a8b177e15b584b1346d4e3c223 Author: mbaxter <[email protected]> Date: Wed Oct 16 11:16:45 2019 -0400 [PIE-2031] Rework sync status events (#106) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 53c47fbc57a2a87fd0f2ae92f3f4895485638f7f Author: Edward <[email protected]> Date: Wed Oct 16 09:13:24 2019 +1000 Prepare for next release (#109) Signed-off-by: Edward Evans <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 1c70acd9db4de0415dad9f652b8fef1a82575e68 Author: MadelineMurray <[email protected]> Date: Wed Oct 16 08:46:09 2019 +1000 1.3.1 release (#105) Signed-off-by: Edward Evans <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 2b1edd8f9b1983323593064f8f8fc824014ae53a Author: Gari Singh <[email protected]> Date: Tue Oct 15 18:37:39 2019 -0400 Update formatting in DCO (#108) The chat link was not properly formatted. Signed-off-by: Gari Singh <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 0f09f2db2053626433cf11409122ac81ed29195a Author: mbaxter <[email protected]> Date: Tue Oct 15 17:23:31 2019 -0400 [PIE-2026] Separate in-sync from sync-status listeners (#100) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 755dfabcc36b8c26640e553f5cb4531fe86dbb5d Author: Lucas Saldanha <[email protected]> Date: Tue Oct 15 14:23:30 2019 +1300 PMC Proposal: Ivaylo Kirilov (#83) Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 8138b37467fadf5be76b6b9fe6ef4257904903a1 Author: Danno Ferrin <[email protected]> Date: Mon Oct 14 18:53:04 2019 +0900 [PAN-3230] Merge BlockchainQueries classes (#101) We had two mostly idenitcal classes used for GraphQL and JsonRPC/WS. This PR merges that to one class. * Move from org.hyperledger.besu.ethereum.api.json.internal.queries to org.hyperledger.besu.ethereum.api.query * Add one method from the GraphQL version (generateLogWithMetadataForTransaction) * Remove graphql version and point graphql to the shared version. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 1dfe5b91e6f5c958561db1fa7f5e901921835510 Author: mark-terry <[email protected]> Date: Fri Oct 11 11:14:36 2019 +1000 [PIE-2023] Fixed casing of dynamic MetricCategorys (#99) * [PIE-2023] Fixed casing of dynamic MetricCategorys Signed-off-by: Mark Terry <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 756eb826d9435b6ed986b0b25e66db48eb24cb9c Author: CJ Hare <[email protected]> Date: Fri Oct 11 09:54:36 2019 +1000 Removing redundant code (#98) Signed-off-by: Christopher Hare <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 6bf9093ed0eaf8f86e7ccb531d9ba6dccda614c1 Author: Abdelhamid Bakhta <[email protected]> Date: Thu Oct 10 17:10:24 2019 +0200 Add totalDiffculty to BlockPropagated events. (#97) * Add totalDiffculty to BlockPropagated events. The chain head block can be contentious with many fork blocks (ommers) propagating on the network. We should add a totalDifficulty to make it easier to see which block is most likely the current head. - added `BlockPropagated` interface in `plugin-api`. - updated `BesuEvents.onBlockPropagated` method to take a `BlockPropagated` instead of a `BlockHeader`. - created `BlockPropagatedSubscriber` in `BlockBroadcaster`. - changed type of `BlockBroadcaster.blockPropagatedSubscribers` from `Consumer<Block>` to `BlockPropagatedSubscriber`. - updated unit tests accordingly to all changes. - updated known hash in `build.gradle` file of `plugin-api`: new value is `4SAeaZIJMsDvUK5Wp2RzU8TlHacslALnM/4yvVhsMtY=` Signed-off-by: Abdelhamid Bakhta <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 3aac9a86eb59e1e775fa4136bed4f764ee10c947 Author: Ivaylo Kirilov <[email protected]> Date: Wed Oct 9 07:15:20 2019 +0100 [PAN-3222] Fix private transactions breaking evm (#96) Signed-off-by: Ivaylo Kirilov <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: edwardmack <[email protected]> commit fa39a97d270babaeecc38b0ce70b2eb3326e7e36 Author: Adrian Sutton <[email protected]> Date: Wed Oct 9 13:36:33 2019 +0900 Make logic in PersistBlockTask more explicit to fix a LGTM warning (#92) Signed-off-by: Adrian Sutton <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 390a9167151662bc05fd7a137fd04fcff29e5345 Author: mbaxter <[email protected]> Date: Tue Oct 8 17:12:52 2019 -0400 [PIE-2003] Make SyncState variables thread-safe (#95) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 1682a1c66c697c6e7680fb117295cacd222b22c9 Author: Danno Ferrin <[email protected]> Date: Tue Oct 8 20:09:09 2019 +0900 [PAN-3223] Add GraphQL query/logs support (#94) Add support for the top level logs query. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit b339b73ad68d581b22ffb3da7314d26cbd1287fa Author: mbaxter <[email protected]> Date: Mon Oct 7 14:19:27 2019 -0400 Fix transaction tracking by sender (#93) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 042442149751a81b626657f2cb200d8a3272f421 Author: mbaxter <[email protected]> Date: Mon Oct 7 03:01:38 2019 -0400 Fix ThreadedNodeRunnner config setup (#90) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 9d544d5dff752e7fa5925fff7730775caa7a0459 Author: mbaxter <[email protected]> Date: Mon Oct 7 03:01:07 2019 -0400 Rework balance checks to use stronger types (#89) Previously you could set an expectation for a balance with a decimal string value, but not a hex string value. This was an error-prone approach. Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit a1b846a9aed9fcfa9019e8f748f658bb7504aa7f Author: Rob Dawson <[email protected]> Date: Mon Oct 7 11:30:17 2019 +0900 Removed Unused methods in the transaction simulator. (#91) Signed-off-by: Rob Dawson <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 5dae7b4a4a8b0a5439dd611dcb13663260fa14dd Author: Peter Robinson <[email protected]> Date: Sun Oct 6 09:07:52 2019 +1100 Round trip testing of state trie account values (#31) Signed-off-by: Peter Robinson <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 7e735f24768a7a435c6a121e23d473cfd8f341d6 Author: CJ Hare <[email protected]> Date: Fri Oct 4 10:13:08 2019 +1000 JsonRpc method disabled error condition rewrite and unit test (#80) Signed-off-by: Christopher Hare <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 266c992965a5f60a3dc5d42f09b5fb8527035ce9 Author: MadelineMurray <[email protected]> Date: Fri Oct 4 09:15:35 2019 +1000 1.3 Changelog Updates (#84) Signed-off-by: Madeline <[email protected]> Signed-off-by: Edward Evans <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 8b5ec324945a82dde88cdc8a3bf8fca38e4f9f27 Author: edwardmack <[email protected]> Date: Thu Oct 3 18:34:04 2019 -0400 Add config params atlantisBlock and aghartaBlock Created code that will handle reading atlantisBlock and aghartaBlock parameters in .json genesis config files. The Protocal Schedule Builder uses these values to add protocol spec definitions. Currently using existing definitons for Atlantis and Agharta, these will be changed to conform to their specs. Signed-off-by: edwardmack <[email protected]> commit c45d0e86b8acc7fc43370574ff4d70b5703f1c3e Author: Ratan Rai Sur <[email protected]> Date: Thu Oct 3 16:07:15 2019 +0100 specify pruning options are minimums (#87) Marking can take longer than the time it takes to accumulate the blocks to satisfy these options. We make no guarantees that exactly the number of blocks in the options will be awaited/kept. Signed-off-by: Ratan Rai Sur <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 06fec825e467d713883961b921a4e2c139dc645c Author: Ratan Rai Sur <[email protected]> Date: Thu Oct 3 15:38:22 2019 +0100 Fixes race condition between `NodeAddedListener` and `FullBlockImportStep` (#56) Fixes race condition between attaching the NodeAddedListener and some state from post marked block being persisted. We now prepare and cleanup the listener only once each, on start and stop respectively. Other changes: Start the Pruner before FullSyncDownloader. Luckily the downloader took enough time to start downloading that this wasn't an issue but it's safer this way. Signed-off-by: Ratan Rai Sur <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 95b29bfb9975d1399252d18797a44e20a3cb1856 Author: Danno Ferrin <[email protected]> Date: Wed Oct 2 20:10:59 2019 -0600 [PAN-3203] add --required-block flag to deal with chainsplits (#79) Add a new CLI flag `--required-block` that takes a block number and a block hash. Before using a peer for syncing we validate that the block exists with the spcified hash at the peer. For example `--required-block=6485846=0x43f0cd1e5b1f9c4d5cda26c240b59ee4f1b510d0a185aa8fd476d091b0097a80` deals with the current Istanbul Ropsten chainsplit. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 20218a95253ec05a9874b0c1c6dfb648c3d2ce6f Author: Ivaylo Kirilov <[email protected]> Date: Wed Oct 2 22:31:48 2019 +0100 add privDistributeTransaction AT (#81) Signed-off-by: Ivaylo Kirilov <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: edwardmack <[email protected]> commit a4a5576d7875f738811027a14b33dc6673ac9bc5 Author: Danno Ferrin <[email protected]> Date: Wed Oct 2 10:14:02 2019 -0600 [minor] add openjdk to platform detector (#74) Add an openjdk case to platform detector, changes client info from `besu/v1.2.4/linux-x86_64/-ubuntu-openjdk64bitservervm-java-11` to `besu/v1.2.4/linux-x86_64/openjdk-java-11` while preserving adoptopenjdk and oracle_openjdk cases. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit b62de65572b440c2a295841594010a6b7fb1ea54 Author: Danno Ferrin <[email protected]> Date: Wed Oct 2 02:40:52 2019 -0600 Check for duplicate Maven coordinates (#75) Add a build task that will enumerate all the maven publications and fail the build if it detects that a duplicate maven coordinate would be used. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: edwardmack <[email protected]> commit d49754826a15685946ddede6fabdefe5c27249bb Author: Edward <[email protected]> Date: Wed Oct 2 10:42:04 2019 +1000 Add CII badge to README (#78) Signed-off-by: Edward Evans <[email protected]> Signed-off-by: edwardmack <[email protected]> commit d13480a2ea6a599532c6cf8bdd6d64e8c3f121cf Author: Lucas Saldanha <[email protected]> Date: Wed Oct 2 09:18:20 2019 +1300 Fixing rocksdb artifact name conflicts (#73) Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 45312685cde7f7ff19a916af5fbd16d87a9f2bd4 Author: Edward <[email protected]> Date: Tue Oct 1 09:07:37 2019 +1000 Prepare for version 1.4.0-SNAPSHOT (#70) Signed-off-by: Edward Evans <[email protected]> Signed-off-by: edwardmack <[email protected]> commit f3d289baf0747159a0ac33a5da5c55746e1c2002 Author: MadelineMurray <[email protected]> Date: Tue Oct 1 08:50:45 2019 +1000 1.3.0-RC1 release (#67) Signed-off-by: Edward Evans <[email protected]> Signed-off-by: edwardmack <[email protected]> commit af062ac1cf30adf573c59158e3fbae7c446a0c63 Author: CJ Hare <[email protected]> Date: Tue Oct 1 07:58:10 2019 +1000 Removing orphaned Javadoc (#64) Signed-off-by: Christopher Hare <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: edwardmack <[email protected]> commit dcd02406704042a8d9f13ea5ffeeefc33ed684bc Author: Danno Ferrin <[email protected]> Date: Mon Sep 30 14:55:05 2019 -0600 Revert "Add CODEOWNERS to match MAINTAINERS (#62)" (#69) This reverts commit bed0731a6b13c93b7ce19718c128a545fd7e8044. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit dfce021b81f34391ab2085d34e27164d358450ea Author: Danno Ferrin <[email protected]> Date: Mon Sep 30 11:03:38 2019 -0600 [PAN-3183] Less verbose synching subscriptions (#59) We should not send a sync status for every forking block state update. Yes, we send status updates for detected forks as well as new canonical heads. Instead we should send a synching message for status changes as well as when we reorg the chain. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 6ad582e0f470ad05eb7396a4ff55b3bb6c4a338a Author: Ry Jones <[email protected]> Date: Mon Sep 30 07:54:32 2019 -0700 Add CODEOWNERS to match MAINTAINERS (#62) Signed-off-by: Ry Jones <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 72aa0bfa5d31314c9c81911308470f556a655d8d Author: edwardmack <[email protected]> Date: Mon Sep 30 10:27:46 2019 -0400 Refactor network name to classic Changed the name of network config from atlantis to classic, and removed agharta config. Signed-off-by: edwardmack <[email protected]> commit 37dd4f5d921ba881c68c4fc327595f5655e8f727 Author: Nicolas MASSART <[email protected]> Date: Mon Sep 30 14:43:10 2019 +0200 add LGTM badges (#68) Signed-off-by: Nicolas MASSART <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 83cabdd1159cc6ed423df7d8415677764d370635 Author: Christian Felde <[email protected]> Date: Mon Sep 30 13:14:29 2019 +0100 [PAN-3023] Add command line option for target gas limit (#24) * [PAN-3023] Add command line option for target gas limit Signed-off-by: cfelde <[email protected]> * [PAN-3023] Add command line option for target gas limit Signed-off-by: Christian Felde <[email protected]> * [PAN-3023] Add command line option for target gas limit Signed-off-by: Christian Felde <[email protected]> * [PAN-3023] Add command line option for target gas limit Signed-off-by: Christian Felde <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 14cfaee0dbd4f359f3aca23bf2229c3e79b3eb78 Author: Joshua Fernandes <[email protected]> Date: Mon Sep 30 18:11:34 2019 +1000 removing azure artifacts and process (#66) Signed-off-by: Joshua Fernandes <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 956f2932b94aecde00be917efc328f87f8a5ad2f Author: CJ Hare <[email protected]> Date: Mon Sep 30 17:33:41 2019 +1000 Adding whitespace to separate words in log message (#65) Signed-off-by: Christopher Hare <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 615e966a40fcab5a480cfe911168f9f9c8ea2ebb Author: mark-terry <[email protected]> Date: Mon Sep 30 15:58:51 2019 +1000 PIE-1858: Infrastructure for exposing PoA metrics for plugins. (#37) [PIE-1858] Added functionality to register custom metrics categories and exposed some PoA data for metrics. Signed-off-by: Mark Terry <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 74e0008ced920b3db53eb28aca8391bfd04ee641 Author: Joshua Fernandes <[email protected]> Date: Mon Sep 30 09:39:37 2019 +1000 Fix docker tags (#60) * fixing the regex to publish to bintray Signed-off-by: Joshua Fernandes <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 59356a72333ca6bf8fa8b2cb7e63bae64ecf5ce2 Author: Josh Richardson <[email protected]> Date: Sun Sep 29 21:46:40 2019 +0100 [PAN-3122] Allow private contracts to access public state (#9) * Allow private contracts to access public state Signed-off-by: Joshua Richardson <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 672f49cc7b9a5c97e1254926fa8ca5fdbc4ac3e3 Author: Ivaylo Kirilov <[email protected]> Date: Sun Sep 29 21:45:03 2019 +0100 refactor-privacy-storage (#7) * refactor-privacy-storage Signed-off-by: Ivaylo Kirilov <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 33551da8112ca66005756c6a56ceb6757746e7fa Author: Ry Jones <[email protected]> Date: Sat Sep 28 17:47:05 2019 -0700 Add default SECURITY policy (#58) Signed-off-by: Ry Jones <[email protected]> Signed-off-by: edwardmack <[email protected]> commit a558488983cf6f22d343f3b186d921a109fe8363 Author: edwardmack <[email protected]> Date: Fri Sep 27 16:24:05 2019 -0400 Added agharta and atlantis config files Signed-off-by: edwardmack <[email protected]> commit 562125f5b6138ac93d16308c658cb980739e5d5f Author: edwardmack <[email protected]> Date: Fri Sep 27 16:17:52 2019 -0400 Add tests for --network agharta and atlantis Added unit test to check correct values are used and values can be overridden for network atlantis and agharta. Added genesis config files atlantis.json and agharta.json. NOTE: these files curretly have place holder values, the actual config for these chains will be determined in the future. Signed-off-by: edwardmack <[email protected]> commit b793e7043370dc9bf1709b2cd7d4f433a50cec63 Author: edwardmack <[email protected]> Date: Fri Sep 27 15:22:45 2019 -0400 Add Atlantis and Agharta network name config Added code to build config for Atlantis or Agharta network. Signed-off-by: edwardmack <[email protected]> commit 8e88b8f18191f10f8815d75a034da8c936ea238c Author: CJ Hare <[email protected]> Date: Thu Sep 26 14:39:39 2019 +1000 Fixing Typo in validation error message (#55) Signed-off-by: Christopher Hare <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 0ceed5f5fec6330feca41e9ea092dc581540bf28 Author: Nicolas MASSART <[email protected]> Date: Thu Sep 26 01:15:34 2019 +0200 Update download link (#54) Signed-off-by: Nicolas MASSART <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 5a8a93bf6372070ef919d0898fca1a5fb5e05d91 Author: Ivaylo Kirilov <[email protected]> Date: Thu Sep 26 00:05:44 2019 +0100 return enclave key instead of private transaction hash (#53) Signed-off-by: Ivaylo Kirilov <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 58fab464c68372d4082bcde0932349dcf4a58df3 Author: mbaxter <[email protected]> Date: Wed Sep 25 15:29:18 2019 -0400 Clean up BesuConfiguration construction (#51) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: edwardmack <[email protected]> commit d94cfdd24b2f48a2e13f1a33da004a47f26655d6 Author: Ratan Rai Sur <[email protected]> Date: Wed Sep 25 20:57:37 2019 +0300 Fix some mark sweep pruner bugs where nodes that should be kept were being swept (Re-merge of #38) (#50) Adds integration tests to catch bug where the mark storage was being cleared before a mark began. Instead, the mark storage is now cleared upon preparing the mark sweep pruner Fixes bug where the pending marks where not being checked while pruning was occurring. By removing the flush in sweepBefore, the existing tests catch the bug. Signed-off-by: Ratan Rai Sur <[email protected]> Signed-off-by: edwardmack <[email protected]> commit 72e975e8e7e415fc396bf26c515fc0f3e8d23fba Author: Danno Ferrin <[email protected]> Date: Mon Nov 4 08:08:49 2019 -0700 Add --identity flag for client identification in node browsers (#150) Support the "--identity" flag. This adds a fifth field to the normally four part clientId, with the identity in the second position. For example, if the CLI flag "--identity PegaSysEng" were passed in the clientID reported by ethernodes would read `besu/PegaSysEng/v1.3.2/linux-x86_64/oracle_openjdk-java-11` Whereas without the flag it would just read `besu/v1.3.2/linux-x86_64/oracle_openjdk-java-11` Signed-off-by: Danno Ferrin <[email protected]> commit 630b5d164060e524f2735fc9432b61af73eb26d2 Author: CJ Hare <[email protected]> Date: Mon Nov 4 17:21:07 2019 +1000 Moving JsonRpcMethods classes into the same package, prior to refactor (#154) Signed-off-by: Christopher Hare <[email protected]> commit 59049f190b365e64f9e5c82fcdc1b7eac9060774 Author: Sally MacFarlane <[email protected]> Date: Mon Nov 4 11:14:20 2019 +1000 edits to test names (#153) Signed-off-by: Sally MacFarlane <[email protected]> commit 38462bb7db9dbd5bd2ec2dcf5c19b87f92522331 Author: Trent Mohay <[email protected]> Date: Fri Nov 1 09:22:48 2019 +1100 Add IbftQueryService to Plugin-api The IbftQueryService has been added to the Plugin-api, along with an implementation. This allows IBFT specific aspects of a block header to be queried (round number, and signers in block). Signed-off-by: Trent Mohay <[email protected]> commit 6b25d406aae68f80e9f67df199854dfc93904fb0 Author: Danno Ferrin <[email protected]> Date: Thu Oct 31 13:19:41 2019 -0600 Istanbul Mainnet Block (#145) Istanbul Mainnet block is 9,069,000. Update mainnet config. Signed-off-by: Danno Ferrin <[email protected]> commit 5ec561a5b30080eab890a7fab054a96ac3e0fb4d Author: Danno Ferrin <[email protected]> Date: Thu Oct 31 12:27:56 2019 -0600 [PAN-3143] Handle zero port better in NAT (#147) When setting the p2p port to zero and turning on UPNP nat an attempt is made to map port zero. This should actually map the opened port instead. The core logic is also now set up to throw an exception if a zero local port is requested. Signed-off-by: Danno Ferrin <[email protected]> commit efb2dc50df13b956d61f23c6eccadfb43818e8e0 Author: Danno Ferrin <[email protected]> Date: Thu Oct 31 08:11:05 2019 -0600 [PAN-3262] Reflect default logging in help (#148) Instead of hard coding the default logging to info reflect the value from the LogManager. Signed-off-by: Danno Ferrin <[email protected]> commit 2a72a3b51c5ebbb977f269a2cc6ef6f8d5af7bef Author: Joshua Fernandes <[email protected]> Date: Thu Oct 31 15:48:30 2019 +1000 adding in circle config (#143) * adding in circle config to publish artifacts * test results * pr fixes Signed-off-by: Joshua Fernandes <[email protected]> commit a48a2de7f5edaa2aeee9257ba6566d0faab0576c Author: Ratan Rai Sur <[email protected]> Date: Wed Oct 30 17:34:45 2019 -0400 Rework how filter and log query parameters are created/used (#146) * Rework how filter and log query parameters are created/used We used a `FilterParameter` that held strings in places where we could create strongly typed objects. We also used it in places where we only wanted a subset of its descriptiveness, namely, the `LogsQuery` part of it. * deserialize directly into `LogsQuery`, which is useful for log pub/sub * narrow uses of `FilterParameter` to `LogsQuery` where possible * make `FilterParameter` hold strongly typed `Address`s and `LogTopic`s Signed-off-by: Ratan Rai Sur <[email protected]> commit a07b45066351901f043e7158a0edf686c1aa56d1 Author: Usman Saleem <[email protected]> Date: Thu Oct 31 06:02:47 2019 +1000 Use gradle root project build dir in check-license (#144) Fixed check-license to use root project's build dir property instead of relative path which resolves to user.dir. Signed-off-by: Usman Saleem <[email protected]> commit 605a6835a1a56f81265371ea8c2d1fe78ec0b896 Author: mbaxter <[email protected]> Date: Tue Oct 29 10:30:10 2019 -0400 [Refactor] Don't generate shutdown tasks in controller (#141) Signed-off-by: Meredith Baxter <[email protected]> commit 952454523cced180698dea408963bc30e0e13438 Author: Kasper Ziemianek <[email protected]> Date: Tue Oct 29 01:32:27 2019 +0100 [PAN-2830] improve message when extraData missing (#121) Signed-off-by: Kasper Ziemianek <[email protected]> commit 70b0fc23cb5ae78c43daba2c084d54397b4997f4 Author: mbaxter <[email protected]> Date: Mon Oct 28 15:53:13 2019 -0400 Fix miner startup logic (#104) Signed-off-by: Meredith Baxter <[email protected]> commit 2ca95c0b613d9ecd94ab0ad3e9e1b3c787969872 Author: pinges <[email protected]> Date: Mon Oct 28 11:37:48 2019 +1000 Rename eea_getTransactionCount to priv_getEeaTransactionCount (#110) Rename eea_getTransactionCount to priv_getEeaTransactionCount Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Jason Frame <[email protected]> commit 7fbdcbcaa9632351b65323331385864e45e714a7 Author: Tim Beiko <[email protected]> Date: Thu Oct 24 15:53:43 2019 -0400 Update ROADMAP.md (#136) Signed-off-by: Tim Beiko <[email protected]> commit 58f2006c8490d20105525a94b9082cca3c27f8d6 Author: Danno Ferrin <[email protected]> Date: Thu Oct 24 11:40:43 2019 -0600 [PAN-3249] Use Bloombits for Logs queries (#127) Use the bloombits for logs queries, so we only have to walk headers and not every receipt on a large query. Signed-off-by: Danno Ferrin <[email protected]> commit d69c92dc1789932843894833f692ceeba1923135 Author: Ratan Rai Sur <[email protected]> Date: Thu Oct 24 11:23:37 2019 -0400 Support log reordring from reorgs in `LogSubscriptionService` (#86) Signed-off-by: Ratan Rai Sur <[email protected]> commit a1948e5c2e607dc0c434ea2e8bd4d7d6752861ff Author: Adrian Sutton <[email protected]> Date: Thu Oct 24 17:33:48 2019 +1000 Ensure spotless runs in CI (#132) Signed-off-by: Adrian Sutton <[email protected]> commit 964cecc4fba5b2e04807d4b668f34d311bd35dd4 Author: Trent Mohay <[email protected]> Date: Thu Oct 24 11:33:55 2019 +1100 Repair EthGetLogs returning incorrect results (#128) An error was detected (PAN-3248) whereby if "Null" appeared in a Log Topic filter, it and all subsequent filters were lost (and thus were not used to filter responses) - thus Besu would return too many results (as the filters were less restrictive than requested). This was determined to be an issue in the TopicParameterDeserialiser which is resolved in this commit. Signed-off-by: Trent Mohay <[email protected]> commit 9027a5f238a2a8735c7d20fe085ca7a26799a44e Author: mbaxter <[email protected]> Date: Wed Oct 23 13:32:55 2019 -0400 [Minor] Add more logging around peer disconnects (#131) Signed-off-by: Meredith Baxter <[email protected]> commit 567a524a2cca39cfe3d5c305861e0e9909722cad Author: Edward <[email protected]> Date: Wed Oct 23 09:18:44 2019 +1000 Prepare for version 1.3.3-SNAPSHOT (#126) Signed-off-by: Edward Evans <[email protected]> commit aee7317bb905a0f1a1c2a39e713a0e9da2ad54c8 Author: MadelineMurray <[email protected]> Date: Wed Oct 23 08:48:48 2019 +1000 1.3.2 release (#125) Signed-off-by: Edward Evans <[email protected]> commit 4a3b693bb18fab6ad47b23099fc54a7244630ab4 Author: Usman Saleem <[email protected]> Date: Tue Oct 22 18:07:08 2019 +1000 [PIE-2052] Besu CLI -V to print plugin versions (#123) -- Use (PicoCLI) custom factory to construct version provider which can return optional plugin versions -- Use plugin's jar manifest implementation and version to build plugin version during plugin registration Signed-off-by: Usman Saleem <[email protected]> commit fcab455ca7166125922f8c5c7a0d08bda7639526 Author: Danno Ferrin <[email protected]> Date: Mon Oct 21 22:30:09 2019 -0600 Update Governance and Code of Conduct verbiage. (#120) The old governance doc does not apply to the Hyperledger project, so it is deleted. Added a note that there is also a HLP code of conduct that also applies. Signed-off-by: Danno Ferrin <[email protected]> commit b4d0327dcefb122887ebcbce7d4f320af90bb9b6 Author: Ivaylo Kirilov <[email protected]> Date: Mon Oct 21 09:48:17 2019 +0100 Fix state root mismatch when trying to modify public state from priv tx (#118) Signed-off-by: Ivaylo Kirilov <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> commit 2039674a38bd22d42ddf28000675c44e3a21a9cb Author: CJ Hare <[email protected]> Date: Mon Oct 21 13:16:44 2019 +1000 Removing duplicate gradle dependency (#122) Signed-off-by: Christopher Hare <[email protected]> commit 48df8290dec122e270fa0fedbf532585a259f0fc Author: Danno Ferrin <[email protected]> Date: Thu Oct 17 16:21:52 2019 -0600 [PAN-3242] Programatically enforce plugin CLI variable names (#117) Enforce that plugin variable names are either `--plugin-<namespace>-` or `--Xplugin-<namespace>-` when registered with the PicoCLIOptionsService. If the names don't match a RuntimeException is thrown, and unless that exception is caught the plugin will not have start or stop lifecycle messages called. Signed-off-by: Danno Ferrin <[email protected]> commit d4b1610fe98209d0c0f8d0be9c24f6816adb35fd Author: mbaxter <[email protected]> Date: Thu Oct 17 10:54:36 2019 -0400 Only set sync targets that have an estimated height value (#115) Signed-off-by: Meredith Baxter <[email protected]> commit 3c82daf149e6e1ab47f877635b6a9e753658ffeb Author: mbaxter <[email protected]> Date: Thu Oct 17 10:53:23 2019 -0400 [Pan 3238] Fix rlpx startup (#114) Signed-off-by: Meredith Baxter <[email protected]> commit e9b2dd24c95f3b43b1fc38df3c1c23bfb0e9f949 Author: Danno Ferrin <[email protected]> Date: Thu Oct 17 07:36:02 2019 -0600 Update dependencies (#112) Upgrade dependencies except rocksdb (needs burn in testing), picocli (reorders options), gradle (causes build server breakage), and web3j (test failures). * Awaitality removed a Duration object and instead uses java.time * jackson stopped throwing a checked exception for one API * spotless now enforces gradle formatting checks (yea!) Signed-off-by: Danno Ferrin <[email protected]> commit 8154874f0540a8a960862fc22b60b333af0b7f26 Author: Abdelhamid Bakhta <[email protected]> Date: Thu Oct 17 09:45:16 2019 +0200 Expose getPayload in Transaction plugin-api interface. (#113) * Expose getPayload in Transaction plugin-api interface. - added `getPayload` in `Transaction` plugin-api interface. - added `@Override` annotation in `Transaction` core object. - updated known hash of `plugin-api`. Signed-off-by: Abdelhamid Bakhta <[email protected]> commit 5fdfba7fa4be93165714472acadc199e18340a8e Author: Jason Frame <[email protected]> Date: Thu Oct 17 16:28:08 2019 +1000 Additional unit test for selecting replaced pending transactions (#116) * Additional unit test for selecting replaced pending transactions Signed-off-by: Jason Frame <[email protected]> commit a410747ff2cb437ac78a018c3f91b872c41f1f91 Author: Abdelhamid Bakhta <[email protected]> Date: Wed Oct 16 18:46:12 2019 +0200 Add hash field in Transaction plugin interface. (#111) Add `hash` field in `Transaction` plugin interface. * - rename `hash` method to `getHash`. - update `plugin-api` known hash. Signed-off-by: Abdelhamid Bakhta <[email protected]> commit 6b472317c2aec3e0065e01ba4e8fecf50fb4c856 Author: mbaxter <[email protected]> Date: Wed Oct 16 11:16:45 2019 -0400 [PIE-2031] Rework sync status events (#106) Signed-off-by: Meredith Baxter <[email protected]> commit b88b313914efc60a415b708140f38c33ba381810 Author: Edward <[email protected]> Date: Wed Oct 16 09:13:24 2019 +1000 Prepare for next release (#109) Signed-off-by: Edward Evans <[email protected]> commit f16254f6d551ae1b9e787009a6302c5d45917164 Author: MadelineMurray <[email protected]> Date: Wed Oct 16 08:46:09 2019 +1000 1.3.1 release (#105) Signed-off-by: Edward Evans <[email protected]> commit 8789b8c222728c7676d573f7d717aaac2b3d9d53 Author: Gari Singh <[email protected]> Date: Tue Oct 15 18:37:39 2019 -0400 Update formatting in DCO (#108) The chat link was not properly formatted. Signed-off-by: Gari Singh <[email protected]> commit 127b92a1ad10605f7f9945c20b59e6b8bc963c0c Author: mbaxter <[email protected]> Date: Tue Oct 15 17:23:31 2019 -0400 [PIE-2026] Separate in-sync from sync-status listeners (#100) Signed-off-by: Meredith Baxter <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> commit fb265f510ae44c88ebd6a9905e1051dd2b6d35b0 Author: Lucas Saldanha <[email protected]> Date: Tue Oct 15 14:23:30 2019 +1300 PMC Proposal: Ivaylo Kirilov (#83) Signed-off-by: Lucas Saldanha <[email protected]> commit 1ca8a94af6f908873e1ae7d76d78359e7dcf9d88 Author: Danno Ferrin <[email protected]> Date: Mon Oct 14 18:53:04 2019 +0900 [PAN-3230] Merge BlockchainQueries classes (#101) We had two mostly idenitcal classes used for GraphQL and JsonRPC/WS. This PR merges that to one class. * Move from org.hyperledger.besu.ethereum.api.json.internal.queries to org.hyperledger.besu.ethereum.api.query * Add one method from the GraphQL version (generateLogWithMetadataForTransaction) * Remove graphql version and point graphql to the shared version. Signed-off-by: Danno Ferrin <[email protected]> commit b926999af2cf764248b4d84b06a11e68a3648760 Author: mark-terry <[email protected]> Date: Fri Oct 11 11:14:36 2019 +1000 [PIE-2023] Fixed casing of dynamic MetricCategorys (#99) * [PIE-2023] Fixed casing of dynamic MetricCategorys Signed-off-by: Mark Terry <[email protected]> commit 502e53cdb2f87d96c553b2aa0186a5f334747933 Author: CJ Hare <[email protected]> Date: Fri Oct 11 09:54:36 2019 +1000 Removing redundant code (#98) Signed-off-by: Christopher Hare <[email protected]> commit 5e819febbdd862736d85371fefc18aa4f1dc7096 Author: Abdelhamid Bakhta <[email protected]> Date: Thu Oct 10 17:10:24 2019 +0200 Add totalDiffculty to BlockPropagated events. (#97) * Add totalDiffculty to BlockPropagated events. The chain head block can be contentious with many fork blocks (ommers) propagating on the network. We should add a totalDifficulty to make it easier to see which block is most likely the current head. - added `BlockPropagated` interface in `plugin-api`. - updated `BesuEvents.onBlockPropagated` method to take a `BlockPropagated` instead of a `BlockHeader`. - created `BlockPropagatedSubscriber` in `BlockBroadcaster`. - changed type of `BlockBroadcaster.blockPropagatedSubscribers` from `Consumer<Block>` to `BlockPropagatedSubscriber`. - updated unit tests accordingly to all changes. - updated known hash in `build.gradle` file of `plugin-api`: new value is `4SAeaZIJMsDvUK5Wp2RzU8TlHacslALnM/4yvVhsMtY=` Signed-off-by: Abdelhamid Bakhta <[email protected]> commit b4f1becc058ca4064c90f3314b6afa4571a3855f Author: Ivaylo Kirilov <[email protected]> Date: Wed Oct 9 07:15:20 2019 +0100 [PAN-3222] Fix private transactions breaking evm (#96) Signed-off-by: Ivaylo Kirilov <[email protected]> Signed-off-by: Lucas Saldanha <[email protected]> commit 9147391634d924092d09d6c2cfd737a377abef63 Author: Adrian Sutton <[email protected]> Date: Wed Oct 9 13:36:33 2019 +0900 Make logic in PersistBlockTask more explicit to fix a LGTM warning (#92) Signed-off-by: Adrian Sutton <[email protected]> commit 13ae4317b7a13cd96e049879e0e6666487fa610c Author: mbaxter <[email protected]> Date: Tue Oct 8 17:12:52 2019 -0400 [PIE-2003] Make SyncState variables thread-safe (#95) Signed-off-by: Meredith Baxter <[email protected]> commit 2626687de1691e04443ef80f16c9a65d6fb8486c Author: Danno Ferrin <[email protected]> Date: Tue Oct 8 20:09:09 2019 +0900 [PAN-3223] Add GraphQL query/logs support (#94) Add support for the top level logs query. Signed-off-by: Danno Ferrin <[email protected]> commit 49e803c8dc1205e288b29be7645ee9d1db21953f Author: mbaxter <[email protected]> Date: Mon Oct 7 14:19:27 2019 -0400 Fix transaction tracking by sender (#93) Signed-off-by: Meredith Baxter <[email protected]> commit 705298228b1d7cc152b093ce5598b20a60530542 Author: mbaxter <[email protected]> Date: Mon Oct 7 03:01:38 2019 -0400 Fix ThreadedNodeRunnner config setup (#90) Signed-off-by: Meredith Baxter <[email protected]> commit 06fd8f93403974c54f197a3429f690e04a6c3268 Author: mbaxter <[email protected]> Date: Mon Oct 7 03:01:07 2019 -0400 Rework balance checks to use stronger types (#89) Previously you could set an expectation for a balance with a decimal string value, but not a hex string value. This was an error-prone approach. Signed-off-by: Meredith Baxter <[email protected]> commit 1d0c4c8f8fd87ba7dc47bb38bd48a4fba16a0fd9 Author: Rob Dawson <[email protected]> Date: Mon Oct 7 11:30:17 2019 +0900 Removed Unused methods in the transaction simulator. (#91) Signed-off-by: Rob Dawson <[email protected]> commit 2c1dded83f87af7beaa84d7122c57414b4ca6a2b Author: Peter Robinson <[email protected]> Date: Sun Oct 6 09:07:52 2019 +1100 Round trip testing of state trie account values (#31) Signed-off-by: Peter Robinson <[email protected]> Signed-off-by: edwardmack <[email protected]>
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Oct 28, 2024
Use direct CL and EL terms for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Make the logic for iterating through blocks and importing in
PersistBlockTasksimpler and clearer. The different behaviour for the first block is now handled before the loop instead of as an if condition within the loop. This makes it clearer to both humans and LGTM thatfutureis never null (https://lgtm.com/projects/g/hyperledger/besu/snapshot/72b95dc86ce4d94aba338c45522656af3116c67e/files/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/tasks/PersistBlockTask.java?sort=name&dir=ASC&mode=heatmap#x57078a84215a57eb:1).