Skip to content

Replace BytesTrieSet with HashSet#9166

Closed
siladu wants to merge 1 commit intohyperledger:mainfrom
siladu:remove-BytesTrieSet
Closed

Replace BytesTrieSet with HashSet#9166
siladu wants to merge 1 commit intohyperledger:mainfrom
siladu:remove-BytesTrieSet

Conversation

@siladu
Copy link
Contributor

@siladu siladu commented Sep 10, 2025

Testing as a fix for #9165

This effectively reverts #6069 by wholesale removing BytesTrieSet and going back to using HashSet as was the case with this PR: #5537

I have measured a notable improvement for the self-destruct worst case, but still need to validate the impact on the other operations.

Before:

Considering tests/benchmark/test_worst_stateful_opcodes.py::test_worst_selfdestruct_existing[fork_Prague-benchmark-gas-value_150M-blockchain_test-value_bearing_False]
Block 1 (0x061b71f5da5b5a167abcaf295a378675e0993301fd27423b8606ba63152b9368) Imported in 22282.17 ms (29.27 MGas/s)
...
Considering tests/benchmark/test_worst_stateful_opcodes.py::test_worst_selfdestruct_existing[fork_Prague-benchmark-gas-value_150M-blockchain_test-value_bearing_True]
Block 1 (0x791e173cea611051e2abc520d2263214a8105c46b5ba7e439a777e4ad04cb428) Imported in 23517.50 ms (27.73 MGas/s)

With this PR:

Considering tests/benchmark/test_worst_stateful_opcodes.py::test_worst_selfdestruct_existing[fork_Prague-benchmark-gas-value_150M-blockchain_test-value_bearing_False]
Block 1 (0x061b71f5da5b5a167abcaf295a378675e0993301fd27423b8606ba63152b9368) Imported in 9895.61 ms (65.91 MGas/s)
Considering tests/benchmark/test_worst_stateful_opcodes.py::test_worst_selfdestruct_existing[fork_Prague-benchmark-gas-value_150M-blockchain_test-value_bearing_True]
Block 1 (0x791e173cea611051e2abc520d2263214a8105c46b5ba7e439a777e4ad04cb428) Imported in 10208.29 ms (63.89 MGas/s)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu self-assigned this Sep 10, 2025
@github-actions
Copy link

This pr is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the Stale label Oct 11, 2025
@github-actions
Copy link

This PR was closed because it has been inactive for 14 days since being marked as stale.

@siladu
Copy link
Contributor Author

siladu commented Jan 15, 2026

Couldn't reopen this PR after force pushing so replaced with #9641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant