Implementation of RIP-7212 / EIP-7951#8750
Merged
garyschulte merged 8 commits intohyperledger:mainfrom Jun 26, 2025
Merged
Conversation
Contributor
|
🔥🔥🔥🔥🔥🔥🔥 |
df00a07 to
d6252b9
Compare
Contributor
05e8c63 to
28a6f83
Compare
Contributor
Author
|
Neither bouncycastle nor OpenSSL secp256r1 verify implementations are particularly performant: |
0286b8c to
d7895e0
Compare
021296b to
e7bfdcb
Compare
9 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jun 11, 2025
a20d5e2 to
0665ae5
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
0665ae5 to
a8fabee
Compare
Contributor
Author
|
As far as I can tell, openssl and boringssl both implement the R' checks for point-at-infinity and R'.x % n ≡ r I asked on eth r&d discord on the #cryptography channel to verify this assertion. |
727be23 to
f6dee81
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
f6dee81 to
bb5f61a
Compare
Contributor
Author
|
this implementation utilizes openssl, and will be superseded by boringssl, but the supporting config, classes and tests will be leveraged by the future besu-native implementation of boringssl |
evm/src/test/java/org/hyperledger/besu/evm/gascalculator/OsakaGasCalculatorTest.java
Show resolved
Hide resolved
Signed-off-by: garyschulte <garyschulte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Draft Implementation of RIP-7212 / EIP-7951.
Outstanding to-dos:
enable non-canonical/malleable signatures (needs besu-native and besu-native-ec changes)benchmarkingcheck/verify malleable signatures with bouncycastleadd secp256r1 to mainnet required native libscachingaddress point-at-infinitymodular comparisonFixed Issue(s)
fixes #8605
blocked by pr 270blocked by pr 22Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests