Skip to content

EIP-7918 blob base fee bounded by execution cost#8724

Merged
macfarla merged 14 commits intohyperledger:mainfrom
macfarla:7918-blob-base-fee-bound-by-execution-cost
Jun 6, 2025
Merged

EIP-7918 blob base fee bounded by execution cost#8724
macfarla merged 14 commits intohyperledger:mainfrom
macfarla:7918-blob-base-fee-bound-by-execution-cost

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Jun 1, 2025

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

PR description

https://eips.ethereum.org/EIPS/eip-7918#functions

Fixed Issue(s)

fixes #8608

TODO

  • confirm test vectors - expecting these to be included in EEST fusaka-devnet-1 release WIP PR
  • check status of this PR after ACDE and update formula if needed

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

macfarla added 5 commits May 30, 2025 13:56
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

macfarla added 4 commits June 2, 2025 12:00
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
macfarla added 4 commits June 4, 2025 13:51
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

macfarla commented Jun 5, 2025

7918 tests passing from devnet-1 EEST release https://github.com/ethereum/execution-spec-tests/releases/tag/fusaka-devnet-1%40v1.0.0

this EIP still draft -> ethereum/EIPs#9855

so I think this PR could go in as is, and follow up with that change if it's merged

@macfarla macfarla marked this pull request as ready for review June 5, 2025 23:34
@macfarla macfarla merged commit b692d48 into hyperledger:main Jun 6, 2025
48 checks passed
@macfarla macfarla deleted the 7918-blob-base-fee-bound-by-execution-cost branch June 26, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EIP-7918: Blob base fee bounded by execution cost

2 participants