Increase the max number of prioritized blob txs in the layered txpool for Pectra #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for Pectra Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
changed the title
garyschulte
approved these changes
Jan 10, 2025
| @@ -75,7 +75,7 @@ enum Implementation { | |||
| long DEFAULT_PENDING_TRANSACTIONS_LAYER_MAX_CAPACITY_BYTES = 12_500_000L; | |||
| int DEFAULT_MAX_PRIORITIZED_TRANSACTIONS = 2000; | |||
| EnumMap<TransactionType, Integer> DEFAULT_MAX_PRIORITIZED_TRANSACTIONS_BY_TYPE = | |||
| new EnumMap<>(Map.of(TransactionType.BLOB, 6)); | |||
| new EnumMap<>(Map.of(TransactionType.BLOB, 9)); | |||
There was a problem hiding this comment.
It would be nice to have an accompanying unit test assertion.
There was a problem hiding this comment.
there are already unit tests that covers this configuration
that is a good point, but requires the configuration to be aware of the protocol schedule and to be updated at runtime to switch to the new value when the fork happens, and that requires a bit of thinking and effort to achieve, so for the moment I prefer to do this simple update and evaluate if it is worth to link it to genesis conf or not, also taking in account the possibility that in future that value is driven by the CL. |
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…for Pectra (hyperledger#8101) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Pectra fork increase the max number of blobs in a block to 9, so this PR allows for a max of 9 blob txs in the layered txpool so Besu can fill the blob space when building a block.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests