Add consolidationRequestContract in jsonGenesisConfig #7647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gconnect <[email protected]>
Signed-off-by: gconnect <[email protected]>
…ntractAddress Signed-off-by: gconnect <[email protected]>
|
@macfarla please review when you have the time. |
Gabriel-Trintinalia
approved these changes
Sep 20, 2024
...e/src/main/java/org/hyperledger/besu/ethereum/mainnet/requests/MainnetRequestsValidator.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
Signed-off-by: gconnect <[email protected]>
|
I am thinking whether I should add this or leave it as it is. Because I noticed it wasn't added |
Signed-off-by: gconnect <[email protected]>
Gabriel-Trintinalia
requested changes
Sep 20, 2024
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
|
@Gabriel-Trintinalia I have made the requested changes. |
gconnect
changed the title
Gabriel-Trintinalia
approved these changes
Sep 24, 2024
Gabriel-Trintinalia
approved these changes
Sep 24, 2024
Wolmin
pushed a commit
to lukso-network/network-besu
that referenced
this pull request
Sep 27, 2024
* Include consolidationRequestContract in jsonGenesisConfigOptions Signed-off-by: gconnect <[email protected]> * Update changelog and ran spotlessApply Signed-off-by: gconnect <[email protected]> * Rename consolidationRequestPredeployAddress to consolidationRequestContractAddress Signed-off-by: gconnect <[email protected]> * Create request contract addresses class Signed-off-by: gconnect <[email protected]> * Update method calls Signed-off-by: gconnect <[email protected]> * Refactor RequestContractAddresses class and update method calls and test Signed-off-by: gconnect <[email protected]> --------- Signed-off-by: gconnect <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Wolmin <[email protected]>
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
fixes #7381
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests