Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending block header to TransactionEvaluationContext #7483

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Aug 19, 2024

PR description

Add pending block header to TransactionEvaluationContext plugin API, so PluginTransactionSelector can access info of the pending block

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the add-pending-block-header-to-TransactionEvaluationContext branch from 19e003a to 42c7bfd Compare August 19, 2024 14:22
@fab-10 fab-10 marked this pull request as ready for review August 19, 2024 14:23
@fab-10 fab-10 requested a review from usmansaleem August 19, 2024 14:23
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem merged commit 19e1a9a into hyperledger:main Aug 19, 2024
40 checks passed
cloudspores pushed a commit to cloudspores/besu that referenced this pull request Aug 20, 2024
…#7483)

Add pending block header to TransactionEvaluationContext plugin API, so PluginTransactionSelector can access info of the pending block.

---
Signed-off-by: Fabio Di Fabio <[email protected]>
Co-authored-by: Usman Saleem <[email protected]>
cloudspores pushed a commit to cloudspores/besu that referenced this pull request Aug 20, 2024
…#7483)

Add pending block header to TransactionEvaluationContext plugin API, so PluginTransactionSelector can access info of the pending block.

---
Signed-off-by: Fabio Di Fabio <[email protected]>
Co-authored-by: Usman Saleem <[email protected]>
Signed-off-by: Ade Lucas <[email protected]>
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
…#7483)

Add pending block header to TransactionEvaluationContext plugin API, so PluginTransactionSelector can access info of the pending block.

---
Signed-off-by: Fabio Di Fabio <[email protected]>
Co-authored-by: Usman Saleem <[email protected]>
Signed-off-by: gconnect <[email protected]>
@fab-10 fab-10 deleted the add-pending-block-header-to-TransactionEvaluationContext branch November 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants