Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In enterprise profile, use sync-mode=FULL and data-storage-format=FOREST #7186

Merged
merged 3 commits into from
Jun 6, 2024
Merged

In enterprise profile, use sync-mode=FULL and data-storage-format=FOREST #7186

merged 3 commits into from
Jun 6, 2024

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Jun 6, 2024 •
edited
Loading

Also remove lower casing of profile names to keep CLI string values consistent with other options

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

siladu added 3 commits June 6, 2024 14:05
@siladu
Use data-storage-format=FOREST in enterprise profile
a4fe537 
Remove lower casing of profile names to keep CLI values consistent
Signed-off-by: Simon Dudley <[email protected]>
@siladu
Use sync-mode=FULL in enterprise profile
5488971 
Signed-off-by: Simon Dudley <[email protected]>
@siladu
Changelog
89b38f3 
Signed-off-by: Simon Dudley <[email protected]>
@siladu siladu changed the title Use data-storage-format=FOREST in enterprise profile In enterprise profile, use sync-mode=FULL and data-storage-format=FOREST Jun 6, 2024
@siladu siladu added the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 6, 2024
matthew1001
matthew1001 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

Gabriel-Trintinalia
Gabriel-Trintinalia approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@siladu siladu enabled auto-merge (squash) June 6, 2024 13:50
@siladu siladu merged commit af663b0 into hyperledger:main Jun 6, 2024
40 checks passed
@siladu siladu deleted the enterprise-profile-default-forest branch June 6, 2024 13:55
@siladu siladu mentioned this pull request Jun 6, 2024
Merged
4 tasks
@joaniefromtheblock joaniefromtheblock mentioned this pull request Jun 19, 2024
Closed
@joaniefromtheblock joaniefromtheblock removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 19, 2024
gtebrean pushed a commit to gtebrean/besu that referenced this pull request Jun 26, 2024
@siladu @gtebrean
In enterprise profile use sync-mode=FULL and data-storage-format=FORE…
fdc8815 
…ST (hyperledger#7186)

Also remove lower casing of profile names to keep CLI values consistent
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: George Tebrean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel-Trintinalia Gabriel-Trintinalia Gabriel-Trintinalia approved these changes

@matthew1001 matthew1001 matthew1001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siladu @matthew1001 @Gabriel-Trintinalia @joaniefromtheblock