Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo #6819 - make yParity and v match #7139

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented May 24, 2024

PR description

Undo PR #6819 -
for 2030 and 1559 transactions both v and yParity will be provided,
and they will be the same number.

Fixed Issue(s)

fixes #7135

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Undo PR hyperledger#6819 -
for 2030 and 1559 transactions both v and yParity will be provided,
and they will be the same number.

Signed-off-by: Danno Ferrin <[email protected]>
shemnon added 3 commits May 24, 2024 06:49
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon enabled auto-merge (squash) May 30, 2024 17:01
@shemnon shemnon merged commit e68c4e1 into hyperledger:main May 30, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: v and yParity aren't matching
2 participants