Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Reference tests v13.1 #6574

Merged
merged 22 commits into from
Feb 16, 2024
Merged

Apply Reference tests v13.1 #6574

merged 22 commits into from
Feb 16, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Feb 14, 2024

PR description

Apply v 13.1 of the reference tests, includes test related fixes around initing the KZG precompile, uint64s in timestamps and blob gas, and some formatting cleanup.

Fixed Issue(s)

jflo and others added 16 commits February 8, 2024 10:50
Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
…net/PermissionTransactionValidator.java

Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
…net/TransactionValidator.java

Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
…net/MainnetTransactionValidatorTest.java

Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Update to new reference tests for cancun.
* Init KZG as part of ReferenceTestProtocolSchedules

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Co-authored-by: : Justin Florentine <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

I detest it, for that there are unit tests.

Signed-off-by: Danno Ferrin <[email protected]>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit in error message

@shemnon shemnon enabled auto-merge (squash) February 16, 2024 17:49
@shemnon shemnon disabled auto-merge February 16, 2024 17:50
@shemnon shemnon enabled auto-merge (squash) February 16, 2024 17:50
@shemnon shemnon merged commit 9e2f471 into hyperledger:main Feb 16, 2024
50 checks passed
suraneti pushed a commit to suraneti/besu that referenced this pull request Feb 24, 2024
Update to new reference tests for cancun.
* Init KZG as part of ReferenceTestProtocolSchedules
* fix unsigned long errors
* block validation on borked blobGasUsed

Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: Justin Florentine <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants