Allow Xpoa-block-txs-selection-max-time to be greater than 100%#6407
Closed
fab-10 wants to merge 3 commits intohyperledger:mainfrom
Closed
Allow Xpoa-block-txs-selection-max-time to be greater than 100%#6407fab-10 wants to merge 3 commits intohyperledger:mainfrom
fab-10 wants to merge 3 commits intohyperledger:mainfrom
Conversation
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
|
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
pinges
reviewed
Jan 16, 2024
Contributor
pinges
left a comment
pinges
left a comment
There was a problem hiding this comment.
Could you explain why it would make sense to do that please.
Otherwise, I think that the changes do achieve what you want to do.
Contributor
Author
|
@pinges because there could be existing networks that are used to have txs that take more than the genesis block time to process, and/or do not care too much about a fixed block time, but more about a target block time, allowing outliers. |
Contributor
Author
|
Close in favor of #6423 |
fab-10
deleted the
Xpoa-block-txs-selection-max-time-greater-than-100
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
In #6044
Xpoa-block-txs-selection-max-timeoptions has been introduced to limit the block creation time to a fraction of the genesis block time, but there are cases where it is useful to let the block creation time last more, so with this PR is it possible to specify value greater than 100%Fixed Issue(s)