-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the high spec flag #6354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: Ameziane H <[email protected] Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: Ameziane H <[email protected] Signed-off-by: Ameziane H <[email protected]>
ahamlat
force-pushed
the
improve-high-spec-flag
branch
from
January 5, 2024 09:15
f9dc86b
to
0081a0d
Compare
Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: Ameziane H <[email protected]>
macfarla
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ahamlat
changed the title
Improve the high spec flag
DO NOT MERGE - Improve the high spec flag
Jan 15, 2024
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: ahamlat <[email protected]>
Signed-off-by: Ameziane H <[email protected]>
…rove-high-spec-flag
Signed-off-by: ahamlat <[email protected]>
ahamlat
changed the title
DO NOT MERGE - Improve the high spec flag
Improve the high spec flag
Jan 24, 2024
Signed-off-by: Ameziane H <[email protected]>
garyschulte
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Improve the high spec flag, limit it to few column families * Update changelog * spotless * Update the plugin API hash as one of the interfaces was changed\ * Fix failing unit tests Signed-off-by: Ameziane H <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Improve the high spec flag (
Xplugin-rocksdb-high-spec-enabled
) by limiting it to only few column families.We can see below the difference in memory usage with this new implementation
Fixed Issue(s)