Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the high spec flag #6354

Merged
merged 11 commits into from
Jan 24, 2024
Merged

Conversation

ahamlat
Copy link
Contributor

@ahamlat ahamlat commented Jan 5, 2024

PR description

Improve the high spec flag (Xplugin-rocksdb-high-spec-enabled) by limiting it to only few column families.

We can see below the difference in memory usage with this new implementation
image

Fixed Issue(s)

Copy link

github-actions bot commented Jan 5, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Signed-off-by: Ameziane H <[email protected]
Signed-off-by: Ameziane H <[email protected]>
@ahamlat ahamlat force-pushed the improve-high-spec-flag branch from f9dc86b to 0081a0d Compare January 5, 2024 09:15
@ahamlat ahamlat marked this pull request as ready for review January 8, 2024 17:41
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@ahamlat ahamlat changed the title Improve the high spec flag DO NOT MERGE - Improve the high spec flag Jan 15, 2024
@ahamlat ahamlat enabled auto-merge (squash) January 24, 2024 11:06
@ahamlat ahamlat changed the title DO NOT MERGE - Improve the high spec flag Improve the high spec flag Jan 24, 2024
Signed-off-by: Ameziane H <[email protected]>
@ahamlat ahamlat merged commit 5277b4a into hyperledger:main Jan 24, 2024
18 checks passed
garyschulte pushed a commit that referenced this pull request Jan 24, 2024
* Improve the high spec flag, limit it to few column families
* Update changelog
* spotless
* Update the plugin API hash as one of the interfaces was changed\
* Fix failing unit tests

Signed-off-by: Ameziane H <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants