New option tx-pool-min-gas-price to set a lower bound when accepting txs to the pool#6098
Merged
fab-10 merged 16 commits intohyperledger:mainfrom Nov 20, 2023
Merged
Conversation
…tx to the pool Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
|
…tx to the pool Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
# Conflicts: # besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/AbstractTransactionPoolTest.java
# Conflicts: # ethereum/blockcreation/src/test/java/org/hyperledger/besu/ethereum/blockcreation/LegacyFeeMarketBlockTransactionSelectorTest.java
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
added
the
doc-change-required
fab-10
force-pushed
the
txpool-min-gas-price
branch
from
fb7e306 to
e0c1d5a
Compare
macfarla
reviewed
Nov 15, 2023
besu/src/main/java/org/hyperledger/besu/cli/options/TransactionPoolOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
macfarla
approved these changes
Nov 20, 2023
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
suggestion re wording, otherwise LGTM
besu/src/main/java/org/hyperledger/besu/cli/options/TransactionPoolOptions.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
# Conflicts: # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/AbstractTransactionPoolTest.java
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 20, 2023
…txs to the pool (hyperledger#6098) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
…txs to the pool (hyperledger#6098) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
alexandratran
removed
the
doc-change-required
gfukushima
pushed a commit
to gfukushima/besu
that referenced
this pull request
Dec 15, 2023
…txs to the pool (hyperledger#6098) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This PR, is related to #6097, and decouples the min gas price (existing
min-gas-priceoption) used when selecting txs during block production, from the min gas price (newtx-pool-min-gas-priceoption) that is required when txs are added to the txpool, since as consequence of #6097, the former min gas price (min-gas-price) can be changed at runtime and using it for evaluation incoming txs in the txpool, could result in strange behavior, where we refuse txs just because their price is just less than themin-gas-price, but since the latter can be later lowered, the same txs could have been included in a block just after a while, for this we want to accept them in the pool.Thus this new option (
tx-pool-min-gas-price) is a static value to set only if you are sure that you never want to process txs with a gas price lower than it, so to exclude what you consider spam txs from polluting your txpool.For that reason
tx-pool-min-gas-pricecan only be less than equal to the start value ofmin-gas-price.